Closed Bug 1741959 Opened 3 years ago Closed 3 years ago

Move audio data processing to ProcessInput

Categories

(Core :: Audio/Video: MediaStreamGraph, task, P1)

Product:
Core
Component:
Audio/Video: MediaStreamGraph
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
97 Branch
Tracking Flags:
Tracking Status
firefox97 --- fixed

People

(Reporter: chunmin, Assigned: chunmin)

References

(Regression)

Details

Attachments

(5 files, 2 obsolete files)

Bug 1741959 - Remove useless comment
(deleted), text/x-phabricator-request
Details
Bug 1741959 - Add debugging logs
(deleted), text/x-phabricator-request
Details
Bug 1741959 - Move NativeInputTrack to individual files
(deleted), text/x-phabricator-request
Details
Bug 1741959 - Move audio data processing to ProcessInput
(deleted), text/x-phabricator-request
Details
Bug 1741959 - Use Maybe for AudioPacketizer to avoid allocations
(deleted), text/x-phabricator-request
Details

The interface for getting the data source of the AudioInputProcessing is in NotifyInputData now. It's better to get its data source from ProcessInput instead. In ProcessInput, we should be able to take an AudioSegment AudioInputTrack's input port souce, so AudioInputTrack can process data from any kind of MediaTrack

Attached file Bug 1741959 - Remove useless comment (deleted) —

This comment should be deleted in Bug 1725810.

Attached file Bug 1741959 - Add debugging logs (deleted) —

Depends on D127605

The following patches will add an abstract MediaTrack for the audio
input devices. The NativeInputTrack will be one implementation of it.
These MediaTracks holding the audio input data should be put together so
this patch moves the NativeInputTrack into individual .h and .cpp files,
which will also be the places implementing this new type of MediaTrack.

Depends on D125626

The interface for getting the data source of the AudioInputProcessing in
AudioInputTrack is moved from AudioInputProcessing::NotifyInputData to
::ProcessInput, which takes an AudioSegment forwarded from the
AudioInputTrack's source track

Depends on D117965

Attached file Bug 1741959 - Add test for NativeInputTrack (obsolete) (deleted) —

Add a simple test checking the data from NativeInputTrack

Depends on D122513

Blocks: 1238038
Blocks: 1729090

Depends on D117965

Replace the data principal in DeviceInputTrack PRINCIPAL_HANDLE_NONE
by a MediaTrackGraph system principal

Depends on D122513

Blocks: 1742655
Attachment #9252036 - Attachment description: Bug 1741959 - Use a system PrincipalHandle for DeviceInputTrack → Bug 1741959 - Use a default PrincipalHandle for audio data in MTG
Blocks: 1744308
Attachment #9252036 - Attachment description: Bug 1741959 - Use a default PrincipalHandle for audio data in MTG → Bug 1741959 - Set a default PrincipalHandle to DeviceInputTrack

Comment on attachment 9252036 [details]
Bug 1741959 - Set a default PrincipalHandle to DeviceInputTrack

Revision D131871 was moved to bug 1746735. Setting attachment 9252036 [details] to obsolete.

Attachment #9252036 - Attachment is obsolete: true

Comment on attachment 9251426 [details]
Bug 1741959 - Add test for NativeInputTrack

Revision D130232 was moved to bug 1746735. Setting attachment 9251426 [details] to obsolete.

Attachment #9251426 - Attachment is obsolete: true
Blocks: 1746735
Pushed by cchang@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9de2c0343e5a Remove useless comment r=padenot https://hg.mozilla.org/integration/autoland/rev/a1a835bfd32c Add debugging logs r=padenot,pehrsons https://hg.mozilla.org/integration/autoland/rev/560f9a2d8a5a Move NativeInputTrack to individual files r=padenot,pehrsons https://hg.mozilla.org/integration/autoland/rev/8a828e078a37 Use Maybe for AudioPacketizer to avoid allocations r=pehrsons https://hg.mozilla.org/integration/autoland/rev/d4ceca3a925a Move audio data processing to ProcessInput r=padenot,pehrsons
Regressed by: 1767891
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: