[Affected versions]:

• Firefox Release 94.0.1 (Build ID:20211103134640)
• Firefox Beta 95.0b9 (Build ID: 20211121185651)
• Firefox Nightly 96.0a1 (Build ID: 20211121212846)

[Affected Platforms]:

• macOS 11.6
• Windows 10 x64
• Windows 11 x64
• Ubuntu 20.04 x64

[Prerequisites]:

• Have the Firefox browser installed.
• Have a Firefox profile with at least one saved login opened.

[Steps to reproduce]:

1. Navigate to the “about:logins: page.
2. Press the “Tab” key until the “Show password” button is focused.
3. Press the “Enter” key and observe the behavior.

[Expected result]:

• The password is shown.

[Actual result]:

• Nothing happens.

[Notes]:

• Also, on the “Create new login” and “Edit” modules, when the “Show password” button is focused and the “Enter” key is pressed, the login is saved instead of showing the password.
• Attached is a screen recording of the issue.

Hey, I would like to work on this defect, can you please let me know from which file this functionality is handled? I tried to look into it but couldn't identify any file that was responsible for handling this feature/issue.

Thanks,
Kaustubh Dapurkar.

Kaustubh welcome and thank you for offering help with this bug!

"Show password" element is a checkbox. Checkboxes react to spacebar, but they do not react to ENTER.
While it works as expected, this is not obvious that it is a checkbox. Most will consider it a button and expect ENTER to work.

Look for reveal-password-checkbox in the source code, this is the class unique to this particular checkbox.

By default, the checkbox supports only the SPACEBAR, w3c documentation here. I couldn't find a non-hacky way to implement the ENTER key functionality.

(In reply to kaustubhdapurkar from comment #4)

By default, the checkbox supports only the SPACEBAR, w3c documentation here. I couldn't find a non-hacky way to implement the ENTER key functionality.

Yeah, I also worry that accessibility users will see it as checkbox and not expect ENTER to work at all.
We could convert it into a regular button and maintain checked state manually.

I've just learned about Bug 502258 which may make this one obsolete.
Lets hold with this one until Bug 1743046 is resolved and we figure the proper way forward.

This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit auto_nag documentation.

Hello, I would like to work on this bug. Is it still available?

(In reply to onyemakonorambrose from comment #8)

Hello, I would like to work on this bug. Is it still available?

My contribution is part of the requirements to be admitted to outreachy internship.

can this bug be assigned to me please? I would like to work on it. Many thanks

The bug will get automatically assigned once you submit a patch. Please go ahead. To make sure everyone has the same opportunities, if there's no progress change in the next few days we'll open it back up to other contributors.

If you have general questions about building firefox or getting your patch together and posted for review, the #introduction matrix channel is your best bet. If you have specific questions about this particular bug, you can post those here.

Hello Sir, I am interested to fix up these issues, can you please assign it to me and you have mentioned the word "patch" what does it mean and how can I submit it?

:being you may want to read here to learn about the process and patches https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html#to-submit-a-patch

Hey, I would like to work on this.
Rather than converting the show password checkbox to a button, we can add a keyboard enter event to the show password checkbox itself. Wouldn't it be feasible?
Thanks!

Hey Janvi, thanks for offering help here!

I'd still suggest to look for other bugs to work on, this one should wait for Bug 1743046 and Bug 1750072.

Manually adding event handlers seems like a simple enough change, but it is usually causing problems later. For example, screen readers still can see it as a checkbox, where SPACE can be used to toggle it, but ENTER doesn't do that. Hitting ENTER while focus is on checkbox, causes form submit button to be clicked. For users who rely on Accessibility it will be an unexpected behavior.

Depends on D143789

Depends on D144281

The bug assignee is inactive on Bugzilla, so the assignee is being reset.

Closing this since this improvement will be tackled as part of this bug 1823943.