Closed
Bug 1742429
Opened 3 years ago
Closed 3 years ago
On Windows, assert that IOUtils/PathUtils input paths may not contain forward slashes
Categories
(Toolkit Graveyard :: OS.File, task, P1)
Toolkit Graveyard
OS.File
Tracking
(firefox96 fixed)
RESOLVED
FIXED
96 Branch
| Tracking | Status | |
|---|---|---|
| firefox96 | --- | fixed |
People
(Reporter: Gijs, Assigned: barret)
References
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
This bit us in bug 1736175, where apparently things work for local paths, but not for UNC paths, which means failures are hard to notice.
If we add debug and/or automation-only assertions/crashes, hopefully we catch any other current or future consumers without having to wait for users to report issues to us.
|
Assignee | |
Comment 1•3 years ago
|
||
|
|
Assignee | |
Updated•3 years ago
|
Severity: -- → S3
Priority: -- → P1
Pushed by brennie@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/db6cd75d5c00
On Windows, assert IOUtils/PathUtils paths do not contain forward slashes r=Gijs
|
||
Comment 3•3 years ago
|
||
Backed out changeset db6cd75d5c00 (Bug 1742429) for causing build bustages on IOUtils.cpp.
Backout link
Push with failures
Failure Log
Flags: needinfo?(brennie)
|
|
Assignee | |
Updated•3 years ago
|
Flags: needinfo?(brennie)
Pushed by brennie@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e8fe8c833448
On Windows, assert IOUtils/PathUtils paths do not contain forward slashes r=Gijs
|
||
Comment 5•3 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 96 Branch
|
||
Updated•2 years ago
|
Product: Toolkit → Toolkit Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•