Closed
Bug 1742437
Opened 3 years ago
Closed 3 years ago
Factor out common ScriptLoadRequest for use in Worker and DOM
Categories
(Core :: DOM: Core & HTML, task, P3)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
99 Branch
| Tracking | Status | |
|---|---|---|
| firefox99 | --- | fixed |
People
(Reporter: yulia, Assigned: yulia)
References
Details
Attachments
(12 files, 2 obsolete files)
|
(deleted),
text/x-phabricator-request
|
Details | |
|
(deleted),
text/x-phabricator-request
|
Details | |
|
(deleted),
text/x-phabricator-request
|
Details | |
|
(deleted),
text/x-phabricator-request
|
Details | |
|
(deleted),
text/x-phabricator-request
|
Details | |
|
(deleted),
text/x-phabricator-request
|
Details | |
|
(deleted),
text/x-phabricator-request
|
Details | |
|
(deleted),
text/x-phabricator-request
|
Details | |
|
(deleted),
text/x-phabricator-request
|
Details | |
|
(deleted),
text/x-phabricator-request
|
Details | |
|
(deleted),
text/x-phabricator-request
|
Details | |
|
(deleted),
text/x-phabricator-request
|
Details |
No description provided.
|
Assignee | |
Updated•3 years ago
|
Priority: -- → P3
|
|
Assignee | |
Comment 1•3 years ago
|
||
|
|
Assignee | |
Comment 2•3 years ago
|
||
Depends on D134040
|
||
Updated•3 years ago
|
Attachment #9255742 -
Attachment description: WIP: Bug 1742437 - (WIP) Split ScriptLoadRequest into ScriptLoadRequestBase and DOM ScriptLoadRequest → Bug 1742437 - Split ScriptLoadRequest into ScriptLoadRequestBase and DOM ScriptLoadRequest; r=jonco
|
|
||
Updated•3 years ago
|
Attachment #9255743 -
Attachment description: WIP: Bug 1742437 - (WIP) Create dom load context object to access base behavior from ScriptLoadRequest → Bug 1742437 - Create dom load context object to access base behavior from ScriptLoadRequest; r=jonco
|
|
Assignee | |
Comment 3•3 years ago
|
||
Depends on D134041
|
|
Assignee | |
Comment 4•3 years ago
|
||
Depends on D136741
|
|
Assignee | |
Comment 5•3 years ago
|
||
Depends on D136742
|
|
Assignee | |
Comment 6•3 years ago
|
||
Depends on D136743
|
|
Assignee | |
Comment 7•3 years ago
|
||
Depends on D136744
|
|
Assignee | |
Comment 8•3 years ago
|
||
Depends on D136745
|
|
||
Updated•3 years ago
|
Attachment #9255743 -
Attachment description: Bug 1742437 - Create dom load context object to access base behavior from ScriptLoadRequest; r=jonco → Bug 1742437 - Split ScriptLoadRequest into ScriptLoadRequest and DOMScriptLoadContext; r=jonco
|
|
||
Updated•3 years ago
|
Attachment #9260393 -
Attachment description: Bug 1742437 - move mIsPreload from ScriptFetchOptions to DOMScriptLoadContext; r=jonco → WIP: Bug 1742437 - move mIsPreload from ScriptFetchOptions to DOMScriptLoadContext, and introduce
|
|
Assignee | |
Comment 9•3 years ago
|
||
Depends on D136746
|
|
||
Updated•3 years ago
|
Attachment #9255742 -
Attachment is obsolete: true
|
|
||
Updated•3 years ago
|
Attachment #9260391 -
Attachment is obsolete: true
|
|
||
Updated•3 years ago
|
Attachment #9260393 -
Attachment description: WIP: Bug 1742437 - move mIsPreload from ScriptFetchOptions to DOMScriptLoadContext, and introduce → Bug 1742437 - move mIsPreload from ScriptFetchOptions to DOMScriptLoadContext, and introduce GetRootModule; r=jonco
|
|
||
Updated•3 years ago
|
Attachment #9260393 -
Attachment description: Bug 1742437 - move mIsPreload from ScriptFetchOptions to DOMScriptLoadContext, and introduce GetRootModule; r=jonco → WIP: Bug 1742437 - move mIsPreload from ScriptFetchOptions to DOMScriptLoadContext, and introduce
|
|
Assignee | |
Comment 10•3 years ago
|
||
Depends on D136746
|
|
Assignee | |
Comment 11•3 years ago
|
||
Depends on D137298
|
|
Assignee | |
Comment 12•3 years ago
|
||
Depends on D137531
|
|
||
Updated•3 years ago
|
Attachment #9260393 -
Attachment description: WIP: Bug 1742437 - move mIsPreload from ScriptFetchOptions to DOMScriptLoadContext, and introduce → Bug 1742437 - move mIsPreload from ScriptFetchOptions to DOMScriptLoadContext, and introduce
|
|
||
Updated•3 years ago
|
Attachment #9260393 -
Attachment description: Bug 1742437 - move mIsPreload from ScriptFetchOptions to DOMScriptLoadContext, and introduce → Bug 1742437 - move mIsPreload from ScriptFetchOptions to DOMScriptLoadContext, and introduce GetRootModule; r=jonco
|
|
||
Updated•3 years ago
|
Attachment #9261271 -
Attachment description: WIP: Bug 1742437 - Create DOM specific Module Loader → Bug 1742437 - Create DOM specific Module Loader; r=jonco,smaug
|
|
||
Updated•3 years ago
|
Attachment #9261690 -
Attachment description: WIP: Bug 1742437 - move DOM module loader into own file → Bug 1742437 - move DOM module loader into own file; r=jonco,smaug
|
|
Assignee | |
Comment 13•3 years ago
|
||
Depends on D137531
|
|
||
Updated•3 years ago
|
Attachment #9261691 -
Attachment description: WIP: Bug 1742437 - Move module loader files into a central folder → Bug 1742437 - Move module loader files into a central folder; r=jonco,smaug
|
|
Assignee | |
Comment 14•3 years ago
|
||
Depends on D137532
|
||
Comment 15•3 years ago
|
||
Pushed by ystartsev@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0ac6d9d26e2b
Split ScriptLoadRequest into ScriptLoadRequest and DOMScriptLoadContext; r=jonco,smaug
https://hg.mozilla.org/integration/autoland/rev/a50f60a612d3
move mElement from ScriptFetchOptions to DOMScriptLoadContext; r=jonco,smaug
https://hg.mozilla.org/integration/autoland/rev/0a5f61274aed
move mIsPreload from ScriptFetchOptions to DOMScriptLoadContext, and introduce GetRootModule; r=jonco,smaug
https://hg.mozilla.org/integration/autoland/rev/9355004c7f6a
move mWebExtGlobal from ScriptLoadRequest to DOMScriptLoadContext; r=jonco,smaug
https://hg.mozilla.org/integration/autoland/rev/729c48e34d6b
move mLineNo from ScriptLoadRequest to DOMScriptLoadContext; r=jonco,smaug
https://hg.mozilla.org/integration/autoland/rev/8b970fb6e4e6
clean up DOMScriptLoadRequest creation; r=jonco,smaug
https://hg.mozilla.org/integration/autoland/rev/c0bd1d29be62
move FireScript.* methods from DOMScriptLoadContext to ScriptLoader;r=jonco,smaug
https://hg.mozilla.org/integration/autoland/rev/f29451ea18dc
Create DOM specific Module Loader; r=jonco
https://hg.mozilla.org/integration/autoland/rev/3a34d557d474
move DOM module loader into own file; r=jonco
https://hg.mozilla.org/integration/autoland/rev/7e54a223001d
move DOM script context into own file and rename it; r=jonco
https://hg.mozilla.org/integration/autoland/rev/a48aff5f2555
Move module loader files into a central folder; r=jonco
https://hg.mozilla.org/integration/autoland/rev/7d5683180ac3
re-scope all generic module/script loader files under js/loader; r=jonco
|
||
Comment 16•3 years ago
|
||
Backed out for causing Bp-hybrid bustages on ModuleLoader.obj
Failure line(s): gmake[4]: *** [/builds/worker/checkouts/gecko/config/rules.mk:660: ModuleLoader.obj] Error 1
Flags: needinfo?(ystartsev)
|
|
||
Comment 17•3 years ago
|
||
Pushed by ystartsev@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/46d45c7bae2f
Split ScriptLoadRequest into ScriptLoadRequest and DOMScriptLoadContext; r=jonco,smaug
https://hg.mozilla.org/integration/autoland/rev/0a3d9301244b
move mElement from ScriptFetchOptions to DOMScriptLoadContext; r=jonco,smaug
https://hg.mozilla.org/integration/autoland/rev/c33b42cabd55
move mIsPreload from ScriptFetchOptions to DOMScriptLoadContext, and introduce GetRootModule; r=jonco,smaug
https://hg.mozilla.org/integration/autoland/rev/ea775927f4ab
move mWebExtGlobal from ScriptLoadRequest to DOMScriptLoadContext; r=jonco,smaug
https://hg.mozilla.org/integration/autoland/rev/130bd544f3f4
move mLineNo from ScriptLoadRequest to DOMScriptLoadContext; r=jonco,smaug
https://hg.mozilla.org/integration/autoland/rev/bf411e44f622
clean up DOMScriptLoadRequest creation; r=jonco,smaug
https://hg.mozilla.org/integration/autoland/rev/467f757b6580
move FireScript.* methods from DOMScriptLoadContext to ScriptLoader;r=jonco,smaug
https://hg.mozilla.org/integration/autoland/rev/e3fe772947bf
Create DOM specific Module Loader; r=jonco
https://hg.mozilla.org/integration/autoland/rev/22649272ffae
move DOM module loader into own file; r=jonco
https://hg.mozilla.org/integration/autoland/rev/967e68ed5f56
move DOM script context into own file and rename it; r=jonco
https://hg.mozilla.org/integration/autoland/rev/0527d227c6b6
Move module loader files into a central folder; r=jonco
https://hg.mozilla.org/integration/autoland/rev/c11cffaded9c
re-scope all generic module/script loader files under js/loader; r=jonco
|
||
Comment 18•3 years ago
|
||
Backed out 12 changesets (bug 1742437) for causing build bustages in dom/script/ScriptTrace.h
Backout link: https://hg.mozilla.org/integration/autoland/rev/ce337b4435dd8364e78208daaca3592409c4554c
INFO - In file included from /builds/worker/checkouts/gecko/dom/script/ModuleLoader.cpp:8:
[task 2022-02-18T13:08:13.141Z] 13:08:13 ERROR - /builds/worker/checkouts/gecko/dom/script/ScriptTrace.h:40:17: error: unused function 'TestingDispatchEvent' [-Werror,-Wunused-function]
[task 2022-02-18T13:08:13.141Z] 13:08:13 INFO - static nsresult TestingDispatchEvent(nsIScriptElement* aScriptElement,
|
|
||
Comment 19•3 years ago
|
||
Pushed by ystartsev@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d52858ae58d2
Split ScriptLoadRequest into ScriptLoadRequest and DOMScriptLoadContext; r=jonco,smaug
https://hg.mozilla.org/integration/autoland/rev/a71a2a98b6bc
move mElement from ScriptFetchOptions to DOMScriptLoadContext; r=jonco,smaug
https://hg.mozilla.org/integration/autoland/rev/835c89a0687b
move mIsPreload from ScriptFetchOptions to DOMScriptLoadContext, and introduce GetRootModule; r=jonco,smaug
https://hg.mozilla.org/integration/autoland/rev/1751a35aae40
move mWebExtGlobal from ScriptLoadRequest to DOMScriptLoadContext; r=jonco,smaug
https://hg.mozilla.org/integration/autoland/rev/ef9a1bd41a68
move mLineNo from ScriptLoadRequest to DOMScriptLoadContext; r=jonco,smaug
https://hg.mozilla.org/integration/autoland/rev/309f151e76bc
clean up DOMScriptLoadRequest creation; r=jonco,smaug
https://hg.mozilla.org/integration/autoland/rev/e96ec49e3e04
move FireScript.* methods from DOMScriptLoadContext to ScriptLoader;r=jonco,smaug
https://hg.mozilla.org/integration/autoland/rev/98d6cb49f4fd
Create DOM specific Module Loader; r=jonco
https://hg.mozilla.org/integration/autoland/rev/0b3f0972e002
move DOM module loader into own file; r=jonco
https://hg.mozilla.org/integration/autoland/rev/7ecc4f9b20ad
move DOM script context into own file and rename it; r=jonco
https://hg.mozilla.org/integration/autoland/rev/85fd9fc9cffa
Move module loader files into a central folder; r=jonco
https://hg.mozilla.org/integration/autoland/rev/b8ecf23519c9
re-scope all generic module/script loader files under js/loader; r=jonco
|
||
Comment 20•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/d52858ae58d2
https://hg.mozilla.org/mozilla-central/rev/a71a2a98b6bc
https://hg.mozilla.org/mozilla-central/rev/835c89a0687b
https://hg.mozilla.org/mozilla-central/rev/1751a35aae40
https://hg.mozilla.org/mozilla-central/rev/ef9a1bd41a68
https://hg.mozilla.org/mozilla-central/rev/309f151e76bc
https://hg.mozilla.org/mozilla-central/rev/e96ec49e3e04
https://hg.mozilla.org/mozilla-central/rev/98d6cb49f4fd
https://hg.mozilla.org/mozilla-central/rev/0b3f0972e002
https://hg.mozilla.org/mozilla-central/rev/7ecc4f9b20ad
https://hg.mozilla.org/mozilla-central/rev/85fd9fc9cffa
https://hg.mozilla.org/mozilla-central/rev/b8ecf23519c9
Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox99:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 99 Branch
|
|
Assignee | |
Updated•3 years ago
|
Flags: needinfo?(ystartsev)
You need to log in
before you can comment on or make changes to this bug.
Description
•