Closed
Bug 1742914
Opened 3 years ago
Closed 3 years ago
Add explicit casts for u8 and u16 parameters to RLBox sandbox_invoke
Categories
(Core :: Security: RLBox, defect, P3)
Core
Security: RLBox
Tracking
()
RESOLVED
FIXED
96 Branch
| Tracking | Status | |
|---|---|---|
| firefox96 | --- | fixed |
People
(Reporter: shravanrn, Assigned: shravanrn)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
This is a short term fix to Bug 1742913 (RLBox wasm plugin is missing a narrowing conversion when passing u16 or u8 parameters)
Here we manually add casts to any sandbox_invoke calls which pass in parameters that are u8 or u16. In the 5 currently sandboxed libraries (graphite, ogg, hunspell, expat, woff2), the only case is MOZ_Xml_StopParser in expat.
|
Assignee | |
Comment 1•3 years ago
|
||
Pushed by bholley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/524df7136a1f
Add explicit casts for u8 and u16 parameters to RLBox sandbox_invoke r=bholley
Backout by csabou@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/694209177262
Backed out changeset 524df7136a1f for causing assertion failures on htmlparser/nsExpatDriver.cpp. CLOSED TREE
Pushed by csabou@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/42c8dae24726
Add explicit casts for u8 and u16 parameters to RLBox sandbox_invoke r=bholley
|
||
Comment 5•3 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox96:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 96 Branch
|
|
||
Comment 6•3 years ago
|
||
| bugherder | ||
You need to log in
before you can comment on or make changes to this bug.
Description
•