Closed Bug 1743099 Opened 3 years ago Closed 3 years ago

Remove unused AddonType bits

Categories

(Toolkit :: Add-ons Manager, task, P2)

Product:
Toolkit
Component:
Add-ons Manager
Type:
task
Points:
3

Tracking

()

Status:
RESOLVED FIXED
Milestone:
98 Branch
Tracking Flags:
Tracking Status
firefox98 --- fixed

People

(Reporter: robwu, Assigned: robwu)

References

(Blocks 1 open bug)

Details

(Whiteboard: [addons-jira])

Attachments

(2 files)

Bug 1743099 - Remove typeListeners from AddonManager
(deleted), text/x-phabricator-request
Details
Bug 1743099 - Replace AddonType with hasAddonType
(deleted), text/x-phabricator-request
Details

AddonType holds information about an addon type, and in particular information about how to render it in the UI.

The UI-specific bits are no longer used, since we replaced the XUL implementation with HTML in bug 1525178 (aType usage was removed in https://hg.mozilla.org/mozilla-central/rev/fb63d8a9e235#l4.662).

Let's remove this so that we can more easily refactor the implementation (e.g. migrating to Fluent in bug 1507471, adding a new addon type in bug 1741544 (D131566)).

From a cursory look, it seems that we can replace it with just a string.

Blocks: aom-code-quality

Originally introduced to support the AddonManager UI, now not used
any more except in one unit test.

Severity: -- → N/A
Priority: -- → P2
Points: --- → 3
Blocks: 1747270
Pushed by rob@robwu.nl: https://hg.mozilla.org/integration/autoland/rev/b4bb7c68938c Remove typeListeners from AddonManager r=rpl https://hg.mozilla.org/integration/autoland/rev/0e6ac6f4e84a Replace AddonType with hasAddonType r=rpl

https://hg.mozilla.org/mozilla-central/rev/b4bb7c68938c
https://hg.mozilla.org/mozilla-central/rev/0e6ac6f4e84a

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox98: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 98 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: