Closed
Bug 1743201
Opened 3 years ago
Closed 3 years ago
Port bug 1432090 - Honor GTK button layout
Categories
(Thunderbird :: Upstream Synchronization, task)
Thunderbird
Upstream Synchronization
Tracking
(thunderbird_esr91 unaffected)
RESOLVED
FIXED
96 Branch
Tracking | Status | |
---|---|---|
thunderbird_esr91 | --- | unaffected |
People
(Reporter: Paenglab, Assigned: Paenglab)
References
Details
Attachments
(1 file)
No description provided.
Assignee | ||
Comment 1•3 years ago
|
||
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9252699 -
Flags: review?(alessandro)
Comment 2•3 years ago
|
||
Comment on attachment 9252699 [details] [diff] [review]
1743201-button-order.patch
Review of attachment 9252699 [details] [diff] [review]:
-----------------------------------------------------------------
This looks good for me on elementary OS, but nothing really changed since that DE has the reversed position.
Pinging both Magnus and Henry to have a look at this since they're on different Linux distros.
Attachment #9252699 -
Flags: review?(mkmelin+mozilla)
Attachment #9252699 -
Flags: review?(henry)
Attachment #9252699 -
Flags: review?(alessandro)
Attachment #9252699 -
Flags: feedback+
Comment 3•3 years ago
|
||
Comment on attachment 9252699 [details] [diff] [review]
1743201-button-order.patch
Review of attachment 9252699 [details] [diff] [review]:
-----------------------------------------------------------------
The result is kind of trivial on GNOME (v40, with Wayland) because it doesn't use minimize or maximize buttons in the window header. So if I set `mail.tabs.drawInTitlebar` to `true` to make this section visible, I still only have the close button (the other two are hidden), so the 'ordering' doesn't matter, so there's nothing to test.
Attachment #9252699 -
Flags: review+
Comment 4•3 years ago
|
||
Comment on attachment 9252699 [details] [diff] [review]
1743201-button-order.patch
LGTM!
Attachment #9252699 -
Flags: review?(mkmelin+mozilla)
Attachment #9252699 -
Flags: review?(henry)
Attachment #9252699 -
Flags: review+
Updated•3 years ago
|
Target Milestone: --- → 96 Branch
Assignee | ||
Updated•3 years ago
|
Keywords: checkin-needed-tb
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/d2444a4140e7
Port bug 1432090 - Honor GTK button layout. r=aleca
You need to log in
before you can comment on or make changes to this bug.
Description
•