Closed
Bug 1743663
Opened 3 years ago
Closed 3 years ago
Crash in [@ mozilla::dom::WindowContext::HasActivePeerConnections]
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
97 Branch
| Tracking | Status | |
|---|---|---|
| firefox-esr91 | --- | unaffected |
| firefox94 | --- | unaffected |
| firefox95 | --- | unaffected |
| firefox96 | + | wontfix |
| firefox97 | --- | fixed |
People
(Reporter: aryx, Assigned: toshi)
References
(Regression)
Details
(Keywords: crash, regression)
Crash Data
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
4 crashes from 3 installations.
Crash report: https://crash-stats.mozilla.org/report/index/35f95a06-802d-4692-bdc1-c99ac0211125
Reason: EXCEPTION_BREAKPOINT
Top 10 frames of crashing thread:
0 xul.dll mozilla::dom::WindowContext::HasActivePeerConnections docshell/base/WindowContext.cpp:74
1 xul.dll mozilla::dom::WindowContext_Binding::get_hasActivePeerConnections dom/bindings/WindowGlobalActorsBinding.cpp:364
2 xul.dll mozilla::dom::binding_detail::GenericGetter<mozilla::dom::binding_detail::NormalThisPolicy, mozilla::dom::binding_detail::ThrowExceptions> dom/bindings/BindingUtils.cpp:3188
3 xul.dll js::Call js/src/vm/Interpreter.cpp:552
4 xul.dll static js::DebuggerObject::call js/src/debugger/Object.cpp:2340
5 xul.dll js::DebuggerObject::CallData::callMethod js/src/debugger/Object.cpp:939
6 xul.dll static js::DebuggerObject::CallData::ToNative<&js::DebuggerObject::CallData::callMethod> js/src/debugger/Object.cpp:241
7 xul.dll InternalCall js/src/vm/Interpreter.cpp:535
8 xul.dll js::jit::DoCallFallback js/src/jit/BaselineIC.cpp:1595
9 @0x2fbab653e8e
Flags: needinfo?(tkikuchi)
|
||
Updated•3 years ago
|
Keywords: regression
|
Assignee | |
Comment 1•3 years ago
|
||
This means a content process loaded TabUnloader.jsm, which is the only one consumer of the new property windowContext.hasActivePeerConnections right now. It's strange, but easy to fix.
Assignee: nobody → tkikuchi
Flags: needinfo?(tkikuchi)
|
|
Assignee | |
Comment 2•3 years ago
|
||
|
||
Updated•3 years ago
|
tracking-firefox96:
--- → +
|
|
||
Comment 3•3 years ago
|
||
Is there an update on this patch? If we want it in 96, I think it would be best in early beta.
Flags: needinfo?(tkikuchi)
Flags: needinfo?(peterv)
|
||
Updated•3 years ago
|
Component: Tabbed Browser → DOM: Core & HTML
Product: Firefox → Core
|
||
Updated•3 years ago
|
Attachment #9253347 -
Attachment description: Bug 1743663 - Call WindowContext::Canonical() only in the parent process. r=peterv → Bug 1743663 - Remove windowContext.hasActivePeerConnections. r=peterv
[Tracking Requested - why for this release]:
Pushed by tkikuchi@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/13a9d145a550
Remove windowContext.hasActivePeerConnections. r=peterv
|
||
Comment 6•3 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox97:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 97 Branch
|
|
Assignee | |
Updated•3 years ago
|
Flags: needinfo?(tkikuchi)
|
|
Assignee | |
Updated•3 years ago
|
Flags: needinfo?(peterv)
|
||
Comment 7•3 years ago
|
||
Toshi, did you want to nominate this for Beta approval?
Flags: needinfo?(tkikuchi)
|
|
Assignee | |
Comment 8•3 years ago
|
||
There are only four reports of this crash and all of them were from nightly. I think we don't need uplift, thanks.
Flags: needinfo?(tkikuchi)
|
||
Updated•3 years ago
|
Has Regression Range: --- → yes
You need to log in
before you can comment on or make changes to this bug.
Description
•