[meta] distutils is deprecated, refactor usages
Categories
(Firefox Build System :: Mach Core, defect, P2)
Tracking
(Not tracked)
People
(Reporter: saschanaz, Unassigned)
References
Details
(Keywords: good-first-bug, meta)
./mach build
shows a warning when running on Python 3.10, and per searchfox I believe it's not only mach build
. See also https://www.python.org/dev/peps/pep-0632/.
Updated•3 years ago
|
Comment 1•3 years ago
|
||
The severity field is not set for this bug.
:mhentges, could you have a look please?
For more information, please visit auto_nag documentation.
Updated•3 years ago
|
Comment 2•3 years ago
|
||
The severity field is not set for this bug.
:mhentges, could you have a look please?
For more information, please visit auto_nag documentation.
Updated•3 years ago
|
Reporter | ||
Updated•3 years ago
|
Updated•3 years ago
|
Comment 4•3 years ago
|
||
Those who need to parse the output of Mach output can hide Python warning output with the PYTHONWARNINGS
environment variable.
E.g.:
PYTHONWARNINGS=ignore ./mach <command>
Updated•3 years ago
|
Comment 5•3 years ago
|
||
This is a great bug for future contributors!
We need to adjust all usages of distutils
to be ported to something that's still maintained.
A couple notes:
- We don't need to port anything in
third_party/python
, ortesting/web-platform/tests/tools/third_party
- There's some helpful
distutils
porting docs here - Let's break down work here by component (
mozbuild
,mozrelease
,mozperftest
, etc), creating "sub-bugs" of this meta bug for each one. - It looks like the majority of changes will be from
distutils.version.LooseVersion
topackaging.version.Version
, and fromdistutils.spawn.find_executable
toshutil.which
Reporter | ||
Comment 6•3 years ago
|
||
testing/web-platform/tests/tools/third_party
Still will be good to have 😉 (but https://github.com/web-platform-tests/wpt is the better place to do it I guess)
Comment 7•3 years ago
|
||
Still will be good to have 😉
True, but those will be solved by updating those vendored dependencies - we shouldn't patch distutils
out of them, because then we're soft-forking the 3rd-party code, which I don't think we want :)
Reporter | ||
Comment 8•3 years ago
|
||
Things in WPT should be automatically synced back to the upstream by wpt-sync bot, so I think that shouldn't be problematic.
Reporter | ||
Comment 9•3 years ago
|
||
Oh actually scratch that, it's third_party in WPT!
Updated•3 years ago
|
Updated•2 years ago
|
Description
•