I added this pref with RECORD_PREF_VALUE instead of RECORD_DEFAULTPREF_VALUE, which means that we don't get the value at all if there's no user-set value.

We'll need to distinguish between clients that have this on/off regardless of who set the pref, so we need to change this to RECORD_DEFAULTPREF_VALUE.

Comment on attachment 9253607 [details]
Data review request

DATA COLLECTION REVIEW RESPONSE:

Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes.

Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is Telemetry so can be controlled through Firefox's Preferences.

If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, Nihanth Subramanya is responsible.

Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1, Technical.

Is the data collection request for default-on or default-off?

Default on for all channels.

Does the instrumentation include the addition of any new identifiers?

No.

Is the data collection covered by the existing Firefox privacy notice?

Yes.

Does the data collection use a third-party collection tool?

No.

Result: datareview+

https://hg.mozilla.org/mozilla-central/rev/e6761d785ebf