Closed Bug 1744606 Opened 3 years ago Closed 3 years ago

Fix warnings in MediaEngineWebRTCAudio.cpp

Categories

(Core :: Audio/Video: MediaStreamGraph, defect, P1)

Product:
Core
Component:
Audio/Video: MediaStreamGraph
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
97 Branch
Tracking Flags:
Tracking Status
firefox97 --- fixed

People

(Reporter: chunmin, Assigned: chunmin)

References

Details

Attachments

(6 files)

Bug 1744606 - Initialize mPacketCount
(deleted), text/x-phabricator-request
Details
Bug 1744606 - Initialize uuid in GetUUID()
(deleted), text/x-phabricator-request
Details
Bug 1744606 - Cast mPacketSize type to int32_t for AppendFrames
(deleted), text/x-phabricator-request
Details
Bug 1744606 - Cast return type of MaxChannels() to int32_t
(deleted), text/x-phabricator-request
Details
Bug 1744606 - Remove unnecessary std::move in ApplySettings
(deleted), text/x-phabricator-request
Details
Bug 1744606 - Remove unnecessary std::move in SetInputProcessing
(deleted), text/x-phabricator-request
Details

Fix the warning for AudioInputProcessing's ctor

WARNING: constructor does not initialize these fields: mPacketCount

update: We have couple of warnings in MediaEngineWebRTCAudio.cpp when running ./mach static-analysis check dom/media/webrtc/MediaEngineWebRTCAudio.cpp. It's better to fix all of them at once.

Summary: Fix WARNING: constructor does not initialize these fields: mPacketCount → Fix warnings in MediaEngineWebRTCAudio.cpp
No longer regressed by: 1741143
Attached file Bug 1744606 - Initialize mPacketCount (deleted) —

Fix warning: constructor does not initialize these fields: mPacketCount [cppcoreguidelines-pro-type-member-init]

Fix warning: uninitialized record type: 'uuid' [cppcoreguidelines-pro-type-member-init]

Depends on D132998

Fix warning: narrowing conversion from 'uint32_t' (aka 'unsigned int') to signed type 'int32_t' (aka 'int') is implementation-defined [cppcoreguidelines-narrowing-conversions]

Depends on D132999

Fix warning: narrowing conversion from 'uint32_t' (aka 'unsigned int') to signed type 'int32_t' (aka 'int') is implementation-defined [cppcoreguidelines-narrowing-conversions]

Depends on D133000

Fix warning: std::move of the const variable 'aAudioProcessingConfig' of the trivially-copyable type 'const AudioProcessing::Config' has no effect; remove std::move() [performance-move-const-arg]

Depends on D133001

Fix warning: std::move of the const expression has no effect; remove std::move() [performance-move-const-arg]

Depends on D133002

Attachment #9253968 - Attachment description: Bug 1744606 - Cast mPacketSize type to int32_t in AppendFrames → Bug 1744606 - Cast mPacketSize type to int32_t for AppendFrames
Pushed by cchang@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8f7e404a09e5 Initialize mPacketCount r=padenot https://hg.mozilla.org/integration/autoland/rev/1ce8566920c7 Initialize uuid in GetUUID() r=padenot https://hg.mozilla.org/integration/autoland/rev/38fe80b50dc9 Cast mPacketSize type to int32_t for AppendFrames r=padenot https://hg.mozilla.org/integration/autoland/rev/cd912504b416 Cast return type of MaxChannels() to int32_t r=padenot https://hg.mozilla.org/integration/autoland/rev/fd342a0df47f Remove unnecessary std::move in ApplySettings r=padenot https://hg.mozilla.org/integration/autoland/rev/82b8e2b360eb Remove unnecessary std::move in SetInputProcessing r=padenot
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: