Closed Bug 1744657 Opened 3 years ago Closed 3 years ago

Add more capability to about:3pane

Categories

(Thunderbird :: Mail Window Front End, enhancement)

enhancement

Tracking

(thunderbird_esr91 wontfix)

RESOLVED FIXED
97 Branch
Tracking Status
thunderbird_esr91 --- wontfix

People

(Reporter: darktrojan, Assigned: darktrojan)

References

(Blocks 1 open bug)

Details

Attachments

(11 files)

(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details
(deleted), text/x-phabricator-request
Details

There's a few things needed here:

  • The <pane-splitter> element needs to be able to handle collapsed panes
  • The 3-pane should respond to items on the view menu for showing/hiding the panes
  • Pane state should be inherited by tabs opened from the current tab, or if that's not available from the XUL store

Several things happening here:

  • Added a new pref mail.useNewMailTabs which determines if about:3pane/about:message is used when opening a folder or a message in a tab.
  • In the shared command controller, added the ability to add more commands. about:3pane can now add commands that don't apply to about:message.
  • Used commands to show/hide folder pane/message pane based on the View menu items. The menu's state doesn't yet reflect the current state of things.
  • Collected the panes' collapsed state and size from the XUL store or from the previous tab.

Depends on D133018

Gonna keep using this bug for more things.

Keywords: leave-open
Summary: Make new 3-pane capable of hiding the folder pane or message preview pane → Add more capability to about:3pane

This cleans up a few broken bits and pieces that stopped the features from working.

Pushed by geoff@darktrojan.net: https://hg.mozilla.org/comm-central/rev/39590ccbb38e Upgrade the <pane-splitter> element to handle collapsed panes. r=mkmelin https://hg.mozilla.org/comm-central/rev/946755386baa Improve the handling of panes in the 3-pane tab. r=mkmelin https://hg.mozilla.org/comm-central/rev/287878e929e5 Fix automatic marking as read, and shrinking overflowing images to fit. r=mkmelin
Target Milestone: --- → 97 Branch

This code will (eventually) perform the actions on the View menu. Some of them will require changes to the menu itself, but those changes aren't included here, as they'd break things.

Pushed by geoff@darktrojan.net: https://hg.mozilla.org/comm-central/rev/72489a725406 Implement commands for navigation, sorting and tags in about:3pane. r=mkmelin
Pushed by geoff@darktrojan.net: https://hg.mozilla.org/comm-central/rev/9f269c96d210 Import missing modules into about:message. r=me

The globals gMessage and gMessageURI only have values if the message pane is open, but in most cases where they are referenced it's the currently selected message we're looking for, which is independent of the message pane state.

Also fixes some methods in nsMsgDBView and JsTreeSelection which give strange responses if no message is selected.

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/d198e6797d17
Stop referencing gMessage[URI] in about:3pane. r=mkmelin
https://hg.mozilla.org/comm-central/rev/922212c4ebd7
Move ConversationOpener to a module so about:3pane can use it. r=mkmelin

Many of these commands will be unusable until changes to the main window, which are not part of this patch, land.

Pushed by geoff@darktrojan.net: https://hg.mozilla.org/comm-central/rev/657d051b8e4a Implement more commands in about:3pane. r=mkmelin https://hg.mozilla.org/comm-central/rev/7ff7209a89a2 Implement commands for handling threads in about:3pane. r=mkmelin https://hg.mozilla.org/comm-central/rev/2c7a69700837 Implement message archiving in about:3pane. r=mkmelin

This folder tree is only a placeholder but it needs to handle added and removed folders or the tests will never pass.

Pushed by geoff@darktrojan.net: https://hg.mozilla.org/comm-central/rev/8f2a2c779534 Make the about:3pane folder tree respond to folder changes. r=mkmelin

Also fixes and enables the test browser_paneFocus.js, which has been broken and disabled since E10s was switched on.
The test doesn't actually pass with about:3pane enabled yet for a few reasons, but at least it passes with about:3pane disabled.

Keywords: leave-open

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/878494ea5f23
Make the F6 key shift focus correctly in about:3pane. r=mkmelin

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: