Closed
Bug 1744842
Opened 3 years ago
Closed 3 years ago
Use vector instead of point to pass scroll __offset__ value to WebRender
Categories
(Core :: Graphics: WebRender, task)
Core
Graphics: WebRender
Tracking
()
RESOLVED
FIXED
97 Branch
| Tracking | Status | |
|---|---|---|
| firefox97 | --- | fixed |
People
(Reporter: hiro, Assigned: hiro)
References
Details
Attachments
(2 files)
I am going to change scroll related APIs in bug 1571758, I realized that using vector would make things easier, thanks to this Glenn's comment
I am going to change wr_dp_define_scroll_layer and wr_transaction_scroll_layer to use vector in this bug. The latter will be changed again to pass multiple already-sampled scroll offsets in bug 1571758
|
Assignee | |
Comment 1•3 years ago
|
||
|
|
Assignee | |
Comment 2•3 years ago
|
||
This includes some other changes;
- Rename relevant functions
scroll_node_with_id -> set_scroll_offset
scroll_node -> set_scroll_offset
set_scroll_origin -> set_scroll_offset - Drop ScrollClamping argument
In Gecko we didn't use ScrollClamping::ToContentBounds at all - The order of arguments of scroll_node_with_id
Depends on D133144
Pushed by hikezoe.birchill@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9fd5635e49d2
Use LayoutVector2D instead of LayoutPoint to set scroll offset (the main-thread part). r=gw,botond
https://hg.mozilla.org/integration/autoland/rev/eef9a8fd017b
Use LayoutVector2D to set scroll offset (the off main-thread part). r=gw,botond
|
||
Comment 4•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/9fd5635e49d2
https://hg.mozilla.org/mozilla-central/rev/eef9a8fd017b
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox97:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 97 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•