Closed Bug 1745444 Opened 3 years ago Closed 3 years ago

Expand FOG IPC to Socket process

Categories

(Toolkit :: Telemetry, task)

Product:
Toolkit
Component:
Telemetry
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
97 Branch
Tracking Flags:
Tracking Status
firefox97 --- fixed

People

(Reporter: florian, Assigned: florian)

References

Details

(Whiteboard: [telemetry:fog:m?])

Attachments

(5 files)

Bug 1745444 - Expand FOG IPC to Socket process, to collect CPU time used there, r=chutten.
(deleted), text/x-phabricator-request
Details
Bug 1745444 - Merge TestTriggerGPUMetrics and TestTriggerRDDMetrics into a method taking a process type as parameter, r=chutten.
(deleted), text/x-phabricator-request
Details
Bug 1745444 - Replace the arbitrary values in RecvTestTriggerMetrics with the PROCESS_TYPE_ constants, r=chutten.
(deleted), text/x-phabricator-request
Details
Bug 1745444 - Add a test for collecting FOG data on the Socket process, r=chutten.
(deleted), text/x-phabricator-request
Details
Bug 1745444 - remove obsolete TestFogIPC gtest, r=chutten.
(deleted), text/x-phabricator-request
Details

+++ This bug was initially created as a clone of Bug #1744162 and bug #1729026 +++

FOG's IPC is currently not present in the socket process. It would be nice to fix this to report the CPU time used in the socket process through Glean.

Blocks: 1745511
Pushed by fqueze@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/497572ee54af Expand FOG IPC to Socket process, to collect CPU time used there, r=chutten,necko-reviewers,valentin. https://hg.mozilla.org/integration/autoland/rev/15d9a79cc305 Merge TestTriggerGPUMetrics and TestTriggerRDDMetrics into a method taking a process type as parameter, r=chutten. https://hg.mozilla.org/integration/autoland/rev/7b9d52dff930 Replace the arbitrary values in RecvTestTriggerMetrics with the PROCESS_TYPE_ constants, r=chutten. https://hg.mozilla.org/integration/autoland/rev/b3a2dc754e16 Add a test for collecting FOG data on the Socket process, r=chutten,necko-reviewers,valentin.

The TestFOGIPC gtests were best-effort attempts to test the IPC within the same process which never really worked out. I think we can remove these tests because they don't really do much of anything at all (and in the case of TestFlushAllChildData it doesn't even hit its ASSERT until after the test bounds are exited). Supplanted by tests/xpcshell/test_GleanIPC.js and friends.

Flags: needinfo?(florian)
Pushed by fqueze@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9525361202e4 Expand FOG IPC to Socket process, to collect CPU time used there, r=chutten,necko-reviewers,valentin. https://hg.mozilla.org/integration/autoland/rev/19aef34fced0 Merge TestTriggerGPUMetrics and TestTriggerRDDMetrics into a method taking a process type as parameter, r=chutten. https://hg.mozilla.org/integration/autoland/rev/081cdfa17669 Replace the arbitrary values in RecvTestTriggerMetrics with the PROCESS_TYPE_ constants, r=chutten. https://hg.mozilla.org/integration/autoland/rev/e9ecd15c7158 Add a test for collecting FOG data on the Socket process, r=chutten,necko-reviewers,valentin. https://hg.mozilla.org/integration/autoland/rev/05eb5b87a4d9 remove obsolete TestFogIPC gtest, r=chutten.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: