Closed Bug 1745610 Opened 3 years ago Closed 2 years ago

Pipewire: Render mouse cursor in Firefox screencast

Categories

(Core :: WebRTC, defect, P3)

defect

Tracking

()

RESOLVED DUPLICATE of bug 1816431

People

(Reporter: stransky, Unassigned)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Follow up from https://bugzilla.mozilla.org/show_bug.cgi?id=1672944#c29

It seems that libwebrtc used by firefox,

https://github.com/mozilla/gecko-dev/blob/master/third_party/libwebrtc/modules/desktop_capture/linux/base_capturer_pipewire.cc

is outdated and does not contain the detection of cursor mode. The new version from google, as pointed out by Dan Shick

https://webrtc.googlesource.com/src/+/refs/heads/main/modules/desktop_capture/linux/base_capturer_pipewire.cc#1035

does contain the detection. So I hope the mozilla developer can upgrade their libwebrtc.

(In reply to Martin Stránský [:stransky] (ni? me) from comment #0)

This link is not publicly accessable:

https://webrtc.googlesource.com/src/+/refs/heads/main/modules/desktop_capture/linux/base_capturer_pipewire.cc#1035

I can find this, and we do not have this code presently:

https://source.chromium.org/chromium/chromium/src/+/main:third_party/webrtc/modules/desktop_capture/linux/base_capturer_pipewire.cc;l=819-833?q=base_capturer_pipewire.cc&ss=chromium

I'm guessing we'll get to this when we get caught up?

Flags: needinfo?(na-g)
Flags: needinfo?(apehrson)

Byron, what are your estimates on cherry-pick-ability?

Flags: needinfo?(na-g) → needinfo?(docfaraday)

Lots of broken links here. It moved to a subdir. This might be a better permalink? https://webrtc.googlesource.com/src/+/73bfa48/modules/desktop_capture/linux/wayland/base_capturer_pipewire.cc#818

Should hopefully not be too bad cherry-picking this. I assume the API hasn't changed much.

Maybe we could try jumping to 5644e55 which is right before the files moved.

Flags: needinfo?(docfaraday)
Flags: needinfo?(apehrson)

I did a simple copy of the files in 5644e55 into our tree and adapted a bit. Blocked on libepoxy headers pretty early.

Severity: -- → S3
Priority: -- → P3
Attached patch Fedora downstream patch (deleted) — Splinter Review

There's a downstream patch used by Fedora/Firefox to backport WebRTC changes.

Attachment #9274019 - Attachment description: libwebrtc-screen-cast-sync.patch → Fedora downstream patch
Status: NEW → RESOLVED
Closed: 2 years ago
Duplicate of bug: 1816431
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: