Closed Bug 1745940 Opened 3 years ago Closed 3 years ago

Implement blackbox lines functionality for the debugger

Categories

(DevTools :: Debugger, enhancement)

enhancement

Tracking

(firefox97 fixed)

RESOLVED FIXED
97 Branch
Tracking Status
firefox97 --- fixed

People

(Reporter: bomsy, Assigned: bomsy)

References

(Blocks 3 open bugs)

Details

Attachments

(2 files)

Full blackboxing lines functionality

See link in https://bugzilla.mozilla.org/show_bug.cgi?id=1690450#c8 for discussions that have been had around blackboxing

This patch includes the following:-

  • The reducer logic to store the blackbox url and range info matches that on the
    server here https://searchfox.org/mozilla-central/rev/dfc0dea63a16b73078a46b6ae49b2a626b8c11b5/devtools/server/actors/utils/sources-manager.js#289-335
    Note: The client logic supports multiple ranges whhile the server supports one range (maybe we can add support for multiple to the server).

  • Added jest tests for some edge cases

  • Changed the asyncStore pref from tabsBlackBoxed to blackboxedTabs for readability ease
    and to avoid and errors as the format of the data stored changes.

    Before: asyncStore.tabsBlackBoxed = ["foo.com", "bar.com"...]
    After: asyncStore.blackboxedTabs = { "foo.com": [], "bar.com": [range, range, ...] }

    The range sturcture

    const range = {
      start: { line: 1, column: 5 },
      end: { line: 3, column: 4 },
    }
    
Assignee: nobody → hmanilla
Status: NEW → ASSIGNED
Depends on: 1746368
Pushed by hmanilla@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7fe99e8b226c
[devtools] Add blackbox line support for actions and reducers r=ochameau
https://hg.mozilla.org/integration/autoland/rev/fb36d632474d
[devtools] Implement blackboxing lines UI functionality r=nchevobbe
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 97 Branch
Regressions: 1746641
Blocks: 1748621
Blocks: 1748620
Blocks: 1748618
Blocks: dbg-blackbox
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: