Make browser/components/shell/test/browser_setDefaultPDFHandler.js Windows 10+
Categories
(Firefox :: Installer, task, P5)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox100 | --- | fixed |
People
(Reporter: nalexander, Assigned: nalexander, Mentored)
References
Details
(Keywords: good-first-bug)
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
I was not aware that we could filter tests by Windows version (like this) when I landed Bug 1743914, which leads to awkward workarounds for Windows 7 (really, Windows <10). I relanded a few times without re-review of the test, which might have shown that we can do better than I did. This ticket tracks doing better.
This could be a good first bug. To fix this, make the browser.ini restrict to Windows 10+, and then remove the guard and level of indentation in the test file itself. To test locally on a Windows 10+ machine, just run
./mach test browser/components/shell/test/browser_setDefaultPDFHandler.js
To verify in try,
./mach try fuzzy -q "'windows 'browser-chrome"
should be sufficient. Make sure that includes any Windows 7 test jobs that still exist!
|
||
Comment 1•3 years ago
|
||
The severity field is not set for this bug.
:nalexander, could you have a look please?
For more information, please visit auto_nag documentation.
|
Assignee | |
Comment 2•3 years ago
|
||
This doesn't impact users so severity is N/A.
|
|
||
Comment 3•3 years ago
|
||
The severity field is not set for this bug.
:nrishel, could you have a look please?
For more information, please visit auto_nag documentation.
|
||
Updated•3 years ago
|
|
|
Assignee | |
Comment 4•3 years ago
|
||
|
||
Updated•3 years ago
|
|
||
Comment 6•3 years ago
|
||
| bugherder | ||
Description
•