Closed Bug 1746662 Opened 3 years ago Closed 2 years ago

Disable CreateSamplingRestrictedDrawable.

Categories

(Core :: Graphics, defect)

defect

Tracking

()

RESOLVED FIXED
105 Branch
Tracking Status
firefox105 --- fixed

People

(Reporter: jrmuizel, Assigned: jrmuizel, NeedInfo)

References

Details

Attachments

(2 files)

No description provided.
Blocks: 1663387
Pushed by jmuizelaar@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/dcc0075d8472
Disable CreateSamplingRestrictedDrawable. r=mstange
Pushed by jmuizelaar@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/68e326b1f0de
Disable CreateSamplingRestrictedDrawable. r=mstange

Backed out for causing reftest failures

Backout link: https://hg.mozilla.org/integration/autoland/rev/c06cc25dc114bba92711e25666162264393c46e0

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=J0rl0l1aSKeIBgmWnkV1TA.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=68e326b1f0de97e59fa4354c1e5a2ef3784e38b2

Failure log: https://treeherder.mozilla.org/logviewer?job_id=362098337&repo=autoland&lineNumber=10272 // https://treeherder.mozilla.org/logviewer?job_id=362097159&repo=autoland&lineNumber=12943 // https://treeherder.mozilla.org/logviewer?job_id=362099756&repo=autoland&lineNumber=31519

Failure line: REFTEST TEST-UNEXPECTED-FAIL | layout/reftests/bugs/421885-1.xml == layout/reftests/bugs/421885-1-ref.xml | image comparison, max difference: 63, number of differing pixels: 1024 // REFTEST TEST-UNEXPECTED-FAIL | layout/reftests/border-image/center-scaling-2.html == layout/reftests/border-image/center-scaling-2-ref.html | image comparison, max difference: 35, number of differing pixels: 4050 // /builds/worker/checkouts/gecko/gfx/thebes/gfxUtils.cpp:300:25: error: code will never be executed [-Werror,-Wunreachable-code]

In case this is not seen at the end of comment 5, this also failed hybrid builds with:
/builds/worker/checkouts/gecko/gfx/thebes/gfxUtils.cpp:300:25: error: code will never be executed [-Werror,-Wunreachable-code]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:jrmuizel, could you have a look please?
For more information, please visit auto_nag documentation.

Flags: needinfo?(mstange.moz)
Flags: needinfo?(jmuizelaar)
Flags: needinfo?(mstange.moz)
Blocks: 1767570
Pushed by jmuizelaar@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/734f0d5f3747
Disable CreateSamplingRestrictedDrawable.
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 105 Branch
Blocks: 1073209
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: