Closed Bug 174692 Opened 22 years ago Closed 14 years ago

gif, bmp, and jpg-format attachments (images) are not displayed from a saved '.eml'-format message (e-mail, email) (rfc2396 rfc822)

Categories

(MailNews Core :: Networking, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED DUPLICATE of bug 707631

People

(Reporter: tho, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [only seamonkey symptoms remaining, see comment 57])

Attachments

(2 files, 1 obsolete file)

User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.1) Gecko/20020826 Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.1) Gecko/20020826 I attached bmp, gif, htm, and jpg-format files to an e-mail and sent it to myself. Upon receipt all of these files displayed when the e-mail was opened from Mozilla's Mail & Newsgroups window. I then saved the file offline (menu: File/Save As/File) and then opened this saved file by double-click. The file was displayed in Mozilla's Navigator window but only the htm-format file displayed (there were horizontally-delimited spaces where the others should have been). A text display showed that the images were present. Reproducible: Always Steps to Reproduce: 1. Compose a message and attach htm, gif, bmp, and jpg files to it. 2. Send the message to yourself. 3. Save the message as a file (menu: File/Save As/File) and open the saved message. Actual Results: Only the htm file displayed. Expected Results: Displayed all of the files. I tried searching for a duplicate bug but Bugzilla kept telling me to activate Javascript even after I had activated it, so I was unable to search.
this has nothing to do with offline.
I'm going to give this to JF for now. He can determine if this is valid or not
Assignee: bienvenu → ducarroz
Component: Offline → Attachments
This may be related to bug 183709, which seems a bit more comprehensive.
bug 183709 is a very recent regression, so I doubt it's related.
Note, testing this again with released 7.02 and trunk build 20030408 on winxop and linux these saved emls still fail but on winxp can be opened with Outlook Express and Netscape 4.7 to display the images.
More note: right click on .eml on desktop on winxp selecting Open With to select 7.02 or current trunk build does not list either of these as apps to open it with. Choose Program to select 7.02 or the current trunk will not allow us to use these apps. Trying to change the file extension eml to open with 7.02 or current trunk isn't possible either. Only 4.7, Outlook Express, Outlook and Internet Explorer are available for this extension. Selecting Internet Explorer will allow this .eml to be displayed with image.
This is similar to bug 88451, which complains about lost attachments in HTML mail -- that bug was changed to an enhancement by ducarroz.
My comment 8 is in error, I misread the referenced bug. I sent myself a message with two attachements, .HTML and .GIF. I saved the message as .EML. Opening the message in the browser showed: [msg text] -------- [HTML rep. of attachment] -------- [broken icon, plus text: "attach.html"] -------- [text: "image.gif"] Besides the image being not displayed, I think the second, broken-icon display of the .html attachment is incorrect as well; since the HTML is being rendered within the page, it's unnecessary, but even if it's considered desirable, it shouldn't have a broken icon. However, I incorporated the same .EML file back into my mail folders, and it displayed correctly. Therefore, the problem this bug describes is an issue with the browser's display of .EML files with attachments. (See also bug 11076, which relates to comment 7.) I don't think this is a MailNews bug at all. An apparent dupe to this bug, bug 175936, is listed as Browser/Networking:HTTP but I don't think that's right either. This testing was done with 1.5 Final, Windows 2000. I'm confirming; I couldn't find a dupe, altho there is a large list of browser bugs with 'mime' in the summary.
Status: UNCONFIRMED → NEW
Ever confirmed: true
*** Bug 204262 has been marked as a duplicate of this bug. ***
*** Bug 234767 has been marked as a duplicate of this bug. ***
Updating Product/Component to Browser/File Handling, per the duplicate.
Component: Attachments → File Handling
Product: MailNews → Browser
OS: Windows 2000 → All
Hardware: PC → All
*** Bug 236094 has been marked as a duplicate of this bug. ***
this is a mailnews bug (in their message/rfc822 stream converter)
Component: File Handling → Networking: MailNews General
Product: Browser → MailNews
(In reply to comment #14) > this is a mailnews bug (in their message/rfc822 stream converter) Are you sure about this? In the mail/news message pane, the attachments show up just fine. Only when viewing a saved message in a browser window, the attachments are corrupted.
Moz 1.7b WinNT4 Weird ... look at the attachment 108377 [details]. First time, only broken image symbols are displayed, but if you select "View Image" from the context menu and go back you will see this image in the eml page. You can continue it for all remaining broken images. But if you reload it, all images are "lost" again. If the eml file is local, the behavior changes slightly. If you do a reload or go back after "view image", you will see the message as source code/plain text. You have to press enter in the location bar to see it again (with images). If you drag 'n' drop it again it will display like on the first time - with broken images.
(In reply to comment #16) > If the eml file is local, the behavior changes slightly. If you do a reload > or go back after "view image", you will see the message as source code/plain > text. You have to press enter in the location bar to see it again [...] That is, to see it again in the browser's built-in RFC822-renderer. This is similar to the problem in bug 223731 -- the "message/rfc822"-ness of the data is lost once it's been streamed as text/html -- but that's not the issue of this bug.
New regression, see bug 239555 comment 14. EML are shown as source code in browser window if not opened as remote URL.
Depends on: 240942
Thunderbird 0.6 for linux also has this bug.
there is a tiny bash script called eml4moz working around this bug: it imports EML content to MOZILLA's mail folders. then, the message can be displayed correct in mozilla's EMAIL CLIENT. to get it: go to http://editive.com/ , choose to edit a blank page, then "Finish" and choose "Save Page and Images". then you can download it there.
Can you give a summary of what that script does please.
here is it: http://209.203.227.117/top-readdoc.php?id=eml4moz pay attention to the usage written in BASH script. (In reply to comment #21) > Can you give a summary of what that script does please.
*** Bug 161715 has been marked as a duplicate of this bug. ***
Summary: gif, bmp, and jpg-format attachments are not displayed from a saved eml-format message → gif, bmp, and jpg-format attachments are not displayed from a saved eml-format message (message/rfc822)
did anybody work with eml4moz successfully? if yes, how did you do that.(with comments in eml4moz, i can't use eml4moz successfully)
(In reply to comment #24) > did anybody work with eml4moz successfully? if yes, how did you do that.(with > comments in eml4moz, i can't use eml4moz successfully) Try this on Linux: 1/ Stop Mozilla 2/ Find the directory /home/$USER/.mozilla/default/$PREFIX.default/Mail/Local Folders/ 3/ echo "From - " >> Sent (this will append "From - " to the file Sent) 4/ cat mail.eml >> Sent (this will content of file mail.eml to the file Sent) 5/ Start Mozilla Try this on Windows: 1/ Stop Thunderbird 2/ Find the directory C:\Documents and Settings\molitor\Application Data\Thunderbird\Profiles\$PREFIX.default\Mail\Local Folders\ 3/ Open the file Sent in this folder with some editor 4/ Append to that File the line "From - " 5/ Append to that File the content of the mail.eml file 6/ Start Thunderbird Regards, Marc
NIAN LIU send me(LIUDIEYU AT UMBRELLA D0T NAME) a message asking for clarification on eml4moz. so i made the text more clear at: http://209.203.227.117/ext-eml4moz please send any feedback to my email address mentioned above. regards, here we go: #!/bin/bash # ***** ***** IMPORTANT ***** ***** # [*]This BASH script helps Mozilla users read MHT/EML files - it works around a Mozilla bug: # "gif, bmp, and jpg-format attachments are not displayed from a saved eml-format message (message/rfc822)" # More description: http://bugzilla.mozilla.org/show_bug.cgi?id=174692 # # [*]How This Script Works # The WEB BROWSER component of Mozilla cannot display MHT/EML files correctly due to the above bug, # but the MAIL component of Mozilla can display MHT/EML well. # This script imports the content of an MHT/EML file into a folder of Mozilla Mail. # # [*]Usage # YOU NEED CUSTOMIZE THIS SCRIPT IF YOU HAVE CUSTOMIZED THE PATH OF "Local Folders" IN MOZILLA MAIL. # Use this command: # $ ./eml4moz mhtml-to-import-to-mozilla.mhtml # then the target file will be imported to mozilla's "Local Folders". # # On KDE/GNOME, you may just configure eml4moz as the default program for handling MHT/EML files, # later double clicking any MHT file would get the clicked file imported into mozilla's "Local Folders". # # # By default, this script will import MHT/EML to the following Mozilla Mail folder: # "Sent" of "Local Folders" of the "default" profile # To change it, just configure: "mozilla_profile" and "mozilla_folder" in this file. # #HISTORY OF THIS FILE #Created by mlsx( - http://mlsx.xplore.cn/ )on 2004-07-13 #Editted by Liu DieYu( - http://umbrella.name ) for clarification and ease to customize #Editted by Liu Die Yu on 20041118: Made the usage text more understandable # # A presentation from Editive( - http://editive.com/ ) # ########## ########## CONFIGURATION START HERE mozilla_profile="default" mozilla_folder="Sent" # ########## ########## CONFIGURATION END HERE file=$1 path="/home/$USER/.mozilla/$mozilla_profile/" cd $path saltdir=`ls |awk -F: '{print $1}'` cd $saltdir cd "Mail/Local Folders" head="From - " if [ -e $mozilla_folder ] then echo $head >>$mozilla_folder cat $file >>$mozilla_folder else touch $mozilla_folder echo $head>>$mozilla_folder cat $file>>$mozilla_folder fi
"wrap" made script of my last post useless, so please download it at: http://209.203.227.117/ext-eml4moz MLSX, NIAN LIU and myself have successfully used this script to import EML/MHT content to MOZILLA MAIL, then use MOZILLA MAIL to display EML/MHT content.(so it does something like what Marc Molitor said - automatically) btw, i found there is no need to stop Mozilla to import EML/MHT file to MOZILLA MAIL on linux.redhat.fedora.core2(thunderbird is not tested :-( ) feedback are welcome at LIUDIEYU AT UMBRELLA D0T NAME regards,
on linux, you can import EML to MOZILLA MAIL with our script automatically: http://209.203.227.117/ext-eml4moz it does the same thing as what you said. on windows, you can use OUTLOOK to import EML to OUTLOOK, then use MOZILLA to import messages from OUTLOOK. all things are done without the target EML parsed by funny&buggy MSHTML component. i hope it helps die - http://editive.com/ (In reply to comment #25) > (In reply to comment #24) > > did anybody work with eml4moz successfully? if yes, how did you do that.(with > > comments in eml4moz, i can't use eml4moz successfully) > > Try this on Linux: > 1/ Stop Mozilla > 2/ Find the directory /home/$USER/.mozilla/default/$PREFIX.default/Mail/Local > Folders/ > 3/ echo "From - " >> Sent (this will append "From - " to the file Sent) > 4/ cat mail.eml >> Sent (this will content of file mail.eml to the file Sent) > 5/ Start Mozilla > > Try this on Windows: > 1/ Stop Thunderbird > 2/ Find the directory C:\Documents and Settings\molitor\Application > Data\Thunderbird\Profiles\$PREFIX.default\Mail\Local Folders\ > 3/ Open the file Sent in this folder with some editor > 4/ Append to that File the line "From - " > 5/ Append to that File the content of the mail.eml file > 6/ Start Thunderbird > > Regards, > > Marc
Product: MailNews → Core
even directly with convert part of image from eml file which is translated from stream converter, image can't show. image can show after right click with view image. any possibility that format "file:///home/neoliu/work/test%20case/gif.eml?part=1.2&type=image/gif&filename=arrow.gif" has something wrong?
Component: MailNews: Networking → ChatZilla
Component: ChatZilla → MailNews: Attachments
Product: Core → Seamonkey
save image in mailer pane, url is translated into *.gif/jpg. that's right. save image in browser, usl is translated into *.eml. that's wrong. a rfc2396 bug
Component: MailNews: Attachments → Networking
Product: Seamonkey → Core
Summary: gif, bmp, and jpg-format attachments are not displayed from a saved eml-format message (message/rfc822) → gif, bmp, and jpg-format attachments are not displayed from a saved eml-format message (rfc2396)
ccing netwerk owner and peer
put in location bar like "file:///home/neoliu/work/test%20case/gif.eml?part=1.1&type=image/gif&filename=arrow.gif" can show arrow correctly. however, put it in an image of an html page like "<IMG SRC="file:///home/neoliu/work/test%20case/gif.eml?part=1.1&type=image/gif&filename=arrow.gif"> can't show arrow correctly. anybody any hints?
The behavior in comment 32 is correct. The file involved is not an image file, but a message/rfc822 file. When loaded directly into the browser, the browser code tries converting it to other formats and finds a conversion to image/gif, then shows the image. When loading as an image, no conversions are attempted (nor should they be, really). The fact that the conversion somehow works for toplevel loads sounds like a bug in the converter to me, by the way -- it converts based on the URI, not the actual data, which is an abuse of the stream converter API. That's the same problem that appears in the attached message. The mailnews "message/rfc822 to *" converter is employed and produces an HTML document with broken links on the <img> tags (the links don't point to content with image content-types, or even image data). The converter needs to generate links that actually point to image data, in other words. Moving to the most-relevant mailnews component.
Assignee: ducarroz → sspitzer
Component: Networking → MailNews: Networking
QA Contact: stephend → grylchan
Summary: gif, bmp, and jpg-format attachments are not displayed from a saved eml-format message (rfc2396) → gif, bmp, and jpg-format attachments are not displayed from a saved eml-format message (rfc2396 rfc822)
image sniff_mime_type makes it runs different with other complex query, such as binary attachment. i even made a patch to add a link for binary attachment when browses eml file in browser to make it accessible in browser. save works almost right for binary attachment(the left uncorrect part is that the saved file name is wrong. however, you can change it manually). binary attachment runs with writeRawBuffer.
Summary: gif, bmp, and jpg-format attachments are not displayed from a saved eml-format message (rfc2396 rfc822) → gif, bmp, and jpg-format attachments (images) are not displayed from a saved eml-format message (e-mail, email) (rfc2396 rfc822)
*** Bug 271649 has been marked as a duplicate of this bug. ***
hange 'eml' in summary to '.eml' for ease of search ('extremly' will hit).
Summary: gif, bmp, and jpg-format attachments (images) are not displayed from a saved eml-format message (e-mail, email) (rfc2396 rfc822) → gif, bmp, and jpg-format attachments (images) are not displayed from a saved '.eml'-format message (e-mail, email) (rfc2396 rfc822)
Blocks: 269826
No longer depends on: 269826
(In reply to comment #33) > > That's the same problem that appears in the attached message. The mailnews > "message/rfc822 to *" converter is employed and produces an HTML document with > broken links on the <img> tags (the links don't point to content with image > content-types, or even image data). Boris, so what the right place to fix it?
In whatever code produces the HTML. It should probably use its own protocol handler, one which only returns the image data and returns the right type... That's the only way I can think of doing this in our arch.
in MimeInlineImage_parse_begin, img element is produced with right link. any more hints?
"right link?" The link points to something that's not image data.
the link itself is generated rightly like "<P><CENTER><IMG SRC=\"file:///home/abc/work/test%20case/gif.eml?part=1.1&type=image/gif&filename=arrow.gif\"></CENTER><P>" so you mean is that MimeInlineImage.image_data is wrong?
I mean that when the data at "file:///home/abc/work/test%20case/gif.eml?part=1.1&type=image/gif&filename=arrow.gif" is gotten by opening a necko channel on it, etc, that data is not an image. It's an eml file. Since the image library can't render eml, it just reports a broken image.
the problem most likely is that nsMailboxProtocol::SetupMessageExtraction() fails on .eml files because there's no message header. I'm working on that now, and if I can fix that, we'll see if it fixes this issue.
Assignee: sspitzer → bienvenu
<img src> does not invoke stream converters
the other part of the problem is nsStreamConverter::DetermineOutputFormat for sub-parts of .eml files opened up thinks we're opening a .eml attachment instead of the actual part because of the ?type=x-message-display left over from the original uri. The attachment uri's end up with two type= terms - maybe we can check for that in nsStreamConverter::DetermineOutputFormat.
David, glad to see you work on that. There is a related bug 284381 which was waited for your sr once. Would you like to sr it now?
(In reply to comment #45) > <img src> does not invoke stream converters Then what's the right place to make <img src> points to the right data?
why not ProxyListener do something as nsStreamConverter as to do the convert for message/rfc822 data?
> Then what's the right place to make <img src> points to the right data? See comment 39. > why not ProxyListener do something as nsStreamConverter as to do the convert > for message/rfc822 data? In general, we don't want image loads running stream converters.... In any case, even if that were done, things like "save image as", "save link as", etc, etc would not work right anyway since Necko would still be returning the wrong data.
(In reply to comment #39) > In whatever code produces the HTML. It should probably use its own protocol > handler, one which only returns the image data and returns the right type... > That's the only way I can think of doing this in our arch. What do you mean "produces" here, the code to generate the html tag from .eml file or the code to rendering img element?
(In reply to comment #51) > > In whatever code produces the HTML. > What do you mean "produces" here, the code to generate the html tag from .eml > file or the code to rendering img element? The code that generates the HTML tag from the .eml. That would be mailnews's stream converter, I guess.
I do have this fixed in my tree...I'm still working on another couple related problems.
*** Bug 312190 has been marked as a duplicate of this bug. ***
*** Bug 312293 has been marked as a duplicate of this bug. ***
should be fixed by patch checked in for bug 204350
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Is it really fixed? The original symptom of this bug involved displaying the .EML file *in the browser*. The suite browser still (1.1a-1030) knows enough about .EML files to style the display of the headers, but also still shows attachments as described in comment 9. (Firefox just tries to open the file in the associated program.) I'm not sure what sort of command line, if any, Seamonkey associates with .EML files when it makes itself the default mail client, and I don't know if there's a specific command-line switch to force a standalong msg window. If you just run seamonkey.exe message.eml you get a browser window. The solution to the problem, as outlined here in the bug, apparently involves core code, but the symptom is strictly Seamonkey. It could be WontFix'd, I suppose.
oh, sorry - re-opening.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Whiteboard: [only seamonkey symptoms remaining, see comment 57]
This bug still exists in Thunderbird. When I receive an e-mail with a forwarded e-mail as attachment that has remote content, the images won't load when you open the attachment and click Show Images. When I choose the option to Display Attachments Inline, I can also click Show Images in the main message and then the images do load, like they should. Steps to reproduce: 1. Send mail with image to yourself (don't attach the image to the message) 2. Forward the received message to yourself 3. Open the attachment in the received message 4. Click Display Images and nothing happens Workaround: 5. Reopen the received message 6. Choose to Display Attachments Inline 7. Click Display Images and the images do load 8. Open the attachment and the images show up to (probably cached)...
QA Contact: grylchan → mailnews.networking
Product: Core → MailNews Core
Assignee: bienvenu → nobody
Status: REOPENED → NEW
This bug still exists on Thunderbird Linux : Steps to reproduce: 1. Send mail with image inlined to yourself 2. save it 3. open it 4. See that the image is not displayed But it works on windows... I am really wondering why ???
It's the same with nightly build of thunderbird 3 for linux.
How to open *.eml files in Firefox (any OS, tested on Linux): 1. Install unMHT extension http://www.unmht.org/unmht/en_index.html 2. Restart firefox after installing extension (firefox will tell you to do this) Since now everytime you want to open *.eml file do this: 1. Rename your *.eml file to *.mht file (or *.eml.mht - file name must end with .mht text). 2. Open in Firefox (File->Open File...). or associate firefox for opening *.mht files with double click in your desktop manager. That's all. I use it on my Linux. Works great. I suspect on Windows Thunderbird might use mshtml engine from Internet Explorer to render eml inside thunderbird window. This way many applications work. I do not use windows so can not confirm this is true or not.
Hi, Here is a small patch fixing the problem. It transfers message size on picture uris, which allows'em to be processed afterwards. Any chance to get a review ? Regards,
Attachment #371427 - Flags: review?
Attachment #371427 - Flags: review? → review?(bienvenu)
Comment on attachment 371427 [details] [diff] [review] Forward image size, which is needed to see attachment on local *.eml files under Linux >Any chance to get a review ? You need to request review.
Comment on attachment 371427 [details] [diff] [review] Forward image size, which is needed to see attachment on local *.eml files under Linux diff --git a/mailnews/local/src/nsMailboxService.cpp b/mailnews/local/src/nsMailboxService.cpp index 406f6e4..c48de42 100644 diff -Nur -x '*.orig' -x '*~' thunderbird-2.0.0.19+nobinonly/build-tree/mozilla/mailnews/local/src/nsMailboxService.cpp thunderbird-2.0.0.19+nobinonly.new/build-tree/mozilla/mailnews/local/src/nsMailboxService.cpp --- mozilla/mailnews/local/src/nsMailboxService.cpp 2006-08-31 00:18:29.000000000 +0200 +++ mozilla/mailnews/local/src/nsMailboxService.cpp 2009-04-07 13:46:04.000000000 +0200 @@ -548,6 +548,18 @@ if (NS_FAILED(rv)) return rv; aMsgUri->SetSpec(newSpec); + + nsCOMPtr <nsIMailboxUrl> aMailboxBaseUrl = do_QueryInterface(aBaseURI, &rv); + nsCOMPtr <nsIMailboxUrl> aMailboxMsgUrl = do_QueryInterface(aMsgUri, &rv); + if (aMailboxMsgUrl && aMailboxBaseUrl) + { + PRUint32 messageSize = 0; + rv = aMailboxBaseUrl->GetMessageSize(&messageSize); + if (rv == NS_OK && messageSize) + { + aMailboxMsgUrl->SetMessageSize(messageSize); + } + } } else {
Ludovic: That's what I have tried, but I do not know if it has succeeded or not.
Attached patch update previous patch (deleted) — Splinter Review
Hi, Sorry for the previous one, here is a cleaner patch. Regards,
Attachment #371427 - Attachment is obsolete: true
Attachment #371429 - Flags: review?(bienvenu)
Attachment #371427 - Flags: review?(bienvenu)
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US;rv:1.9.1b5pre) Gecko/20090425 SeaMonkey/2.0b1pre only to note that the behavior from comment 16 is now the following: eml file opened locally per "Open File": images are at first not shown (broken), do "View Image", you will see only the internal URL, do a reload, now you see the image, go back and press enter in the location bar to see the mail message with the image. eml file opened remotely per link (e.g. bugzilla attachment): images are at first not shown (broken), do "View Image", you will see it, go back and (do a reload if you don't see the image) the image displays inside the message.
this seems to work fine for me with a seamonkey trunk build, so marking wfm. Please re-open if you disagree.
Status: NEW → RESOLVED
Closed: 19 years ago14 years ago
Resolution: --- → WORKSFORME
Comment on attachment 371429 [details] [diff] [review] update previous patch cancelling review
Attachment #371429 - Flags: review?(bienvenu)
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:11.0a1) Gecko/20111210 SeaMonkey/2.8a1 It works with SeaMonkey MailNews now, but still does not work with SeaMonkey Browser, as this bug is about (see comment 0). But the opening of .eml files in the browser is not intended behaviour anymore. So duping to bug 707631.
Resolution: WORKSFORME → DUPLICATE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: