Closed
Bug 1748328
Opened 3 years ago
Closed 3 years ago
"mach wpt" on mobile fails to use default device serial since bug 1741242
Categories
(Testing :: web-platform-tests, defect)
Tracking
(firefox-esr91 unaffected, firefox95 unaffected, firefox96 unaffected, firefox97 fixed)
RESOLVED
FIXED
97 Branch
| Tracking | Status | |
|---|---|---|
| firefox-esr91 | --- | unaffected |
| firefox95 | --- | unaffected |
| firefox96 | --- | unaffected |
| firefox97 | --- | fixed |
People
(Reporter: whimboo, Assigned: jgraham)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file, 1 obsolete file)
|
(deleted),
text/x-phabricator-request
|
Details |
Since the downstream wpt sync for bug 1741242 has been landed on mozilla-central I'm no longer able to run tests except when I explicitly specify the device serial. The output is the following:
ERROR Traceback (most recent call last):
File "/Users/henrik/code/gecko/testing/web-platform/tests/tools/wptrunner/wptrunner/testrunner.py", line 209, in init
self.browser.start(group_metadata=group_metadata, **self.browser_settings)
File "/Users/henrik/code/gecko/testing/web-platform/tests/tools/wptrunner/wptrunner/browsers/firefox_android.py", line 231, in start
self.runner = FennecEmulatorRunner(app=self.package_name,
File "/Users/henrik/code/gecko/testing/mozbase/mozrunner/mozrunner/runners.py", line 127, in FennecEmulatorRunner
kwargs["app_ctx"] = get_app_context("fennec")(
File "/Users/henrik/code/gecko/testing/mozbase/mozrunner/mozrunner/application.py", line 113, in __init__
self.device = self.get_device(self.adb, device_serial)
File "/Users/henrik/code/gecko/testing/mozbase/mozrunner/mozrunner/application.py", line 120, in get_device
if device_serial in devices:
TypeError: unhashable type: 'list'
The underlying problem is the new default value of [] for the --device-serial argument. Because of that we no longer apply emulator-5554 as default for FennecEmulatorRunner.
|
Reporter | |
Comment 1•3 years ago
|
||
|
||
Updated•3 years ago
|
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
|
||
Comment 2•3 years ago
|
||
Set release status flags based on info from the regressing bug 1741242
status-firefox95:
--- → unaffected
status-firefox-esr91:
--- → unaffected
|
|
||
Updated•3 years ago
|
Attachment #9257376 -
Attachment is obsolete: true
|
|
Reporter | |
Comment 3•3 years ago
|
||
As discussed on Element James is going to fix this bug.
Assignee: hskupin → james
|
Assignee | |
Comment 4•3 years ago
|
||
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/autoland/rev/00ae789d0d85
Pass a default device-serial when running Firefox for android, r=whimboo
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/32255 for changes under testing/web-platform/tests
|
||
Comment 7•3 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 97 Branch
Upstream PR merged by moz-wptsync-bot
|
|
||
Updated•3 years ago
|
Has Regression Range: --- → yes
You need to log in
before you can comment on or make changes to this bug.
Description
•