Write a test for bug 1748408
Categories
(Core :: Spelling checker, defect)
Tracking
()
People
(Reporter: emilio, Unassigned)
References
Details
Bobby pointed me to https://searchfox.org/mozilla-central/source/extensions/spellcheck/hunspell/tests/unit
Reporter | ||
Updated•3 years ago
|
Reporter | ||
Comment 1•3 years ago
|
||
So just having a large enough N in the AF <N>
field in the dictionary is enough to trigger this bug, but without a complete dictionary then we hit various issues (both leaks and frees of uninit memory) in hunspell, which I submitted a fix for in https://github.com/hunspell/hunspell/pull/756.
Bobby, I could add the whole Hungarian dictionary to the tree if you want (since it's under an MPL license), but otherwise the tests added in https://github.com/hunspell/hunspell/pull/756 should cover this case once we update hunspell and so on. Thoughts?
Comment 2•3 years ago
|
||
(In reply to Emilio Cobos Álvarez (:emilio) from comment #1)
So just having a large enough N in the
AF <N>
field in the dictionary is enough to trigger this bug, but without a complete dictionary then we hit various issues (both leaks and frees of uninit memory) in hunspell, which I submitted a fix for in https://github.com/hunspell/hunspell/pull/756.Bobby, I could add the whole Hungarian dictionary to the tree if you want (since it's under an MPL license), but otherwise the tests added in https://github.com/hunspell/hunspell/pull/756 should cover this case once we update hunspell and so on. Thoughts?
That seems fine, adding the whole dictionary is probably overkill. Thanks!
Updated•3 years ago
|
Description
•