Closed Bug 1748699 Opened 3 years ago Closed 3 years ago

Write a test for bug 1748408

Categories

(Core :: Spelling checker, defect)

defect

Tracking

()

RESOLVED MOVED

People

(Reporter: emilio, Unassigned)

References

Details

So just having a large enough N in the AF <N> field in the dictionary is enough to trigger this bug, but without a complete dictionary then we hit various issues (both leaks and frees of uninit memory) in hunspell, which I submitted a fix for in https://github.com/hunspell/hunspell/pull/756.

Bobby, I could add the whole Hungarian dictionary to the tree if you want (since it's under an MPL license), but otherwise the tests added in https://github.com/hunspell/hunspell/pull/756 should cover this case once we update hunspell and so on. Thoughts?

Flags: needinfo?(emilio) → needinfo?(bholley)

(In reply to Emilio Cobos Álvarez (:emilio) from comment #1)

So just having a large enough N in the AF <N> field in the dictionary is enough to trigger this bug, but without a complete dictionary then we hit various issues (both leaks and frees of uninit memory) in hunspell, which I submitted a fix for in https://github.com/hunspell/hunspell/pull/756.

Bobby, I could add the whole Hungarian dictionary to the tree if you want (since it's under an MPL license), but otherwise the tests added in https://github.com/hunspell/hunspell/pull/756 should cover this case once we update hunspell and so on. Thoughts?

That seems fine, adding the whole dictionary is probably overkill. Thanks!

Flags: needinfo?(bholley)
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → MOVED
You need to log in before you can comment on or make changes to this bug.