Closed
Bug 174910
Opened 22 years ago
Closed 21 years ago
Mutation events inside anchor elements are not propogated up in tree
Categories
(Core :: DOM: UI Events & Focus Handling, defect, P2)
Tracking
()
RESOLVED
FIXED
People
(Reporter: aaronlev, Assigned: aaronlev)
References
Details
(Keywords: access, topembed, Whiteboard: [Waitng for sr=jst] Creates potential crashes and other problems in accessibility)
Attachments
(2 files, 1 obsolete file)
(deleted),
text/html
|
Details | |
(deleted),
patch
|
bryner
:
review+
jst
:
superreview+
|
Details | Diff | Splinter Review |
When a mutation event such as DOMAttrModified, DOMNodeInserted or DOMNodeRemoved
occurs somewhere inside an <a>, it is swallowed.
I think this has something to do with the event ending up in
nsGenericHTMLElement::HandleDOMEventForAnchors() and going no further.
Assignee | ||
Comment 1•22 years ago
|
||
Comment 2•22 years ago
|
||
joki is gone, -> me.
Aaron, is this blocking anything?
Assignee: joki → bryner
Assignee | ||
Comment 3•22 years ago
|
||
Yes, but I'm not sure what the priority should be. It would be nice to get it
fixed by January/February.
Blocks: 149654
Updated•22 years ago
|
QA Contact: rakeshmishra → trix
Assignee | ||
Comment 4•21 years ago
|
||
Now that the accessibility cache is implemented using mutation events, this is
an important bug. If we don't fix it, the accessibility APIs could report
incorrect data for some pages, and it would inevitably lead to crashes.
Assignee | ||
Comment 5•21 years ago
|
||
Assignee | ||
Updated•21 years ago
|
Attachment #124720 -
Flags: review?(bryner)
Assignee | ||
Comment 6•21 years ago
|
||
Other DOM events generated without a pres context would be swallowed by anchors
as well.
Comment 7•21 years ago
|
||
Comment on attachment 124720 [details] [diff] [review]
Shouldn't event get propogated up DOM tree even when aPresContext argument == nsnull?
I'd suggest keeping the aEventStatus check as-is, and moving the aPresContext
check like you suggested. However, I think it should be changed to an early
return and not use NS_ENSURE_ARG (that macro implies and unexpected condition
and spews to the console).
I'm also curious why this event doesn't have an aPresContext parameter.
Assignee | ||
Comment 8•21 years ago
|
||
There's no pres context because the event is generated by the code in
mozilla/content itself, for example nsGenericHTMLElement::SetAttr() or
::InsertChildAt()
Attachment #124720 -
Attachment is obsolete: true
Assignee | ||
Updated•21 years ago
|
Attachment #124799 -
Flags: review?(bryner)
Assignee | ||
Updated•21 years ago
|
Attachment #124720 -
Flags: review?(bryner)
Assignee | ||
Updated•21 years ago
|
Attachment #124799 -
Flags: superreview?(jst)
Updated•21 years ago
|
Attachment #124799 -
Flags: review?(bryner) → review+
Assignee | ||
Comment 9•21 years ago
|
||
Patch ready.
Assignee: bryner → aaronl
Whiteboard: Creates potential crashes and other problems in accessibility → [Waitng for sr=jst] Creates potential crashes and other problems in accessibility
Comment 10•21 years ago
|
||
Comment on attachment 124799 [details] [diff] [review]
New patch with bryner's suggestions
sr=jst
Attachment #124799 -
Flags: superreview?(jst) → superreview+
Assignee | ||
Comment 11•21 years ago
|
||
this has been checked in
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Component: Event Handling → User events and focus handling
Comment 12•6 years ago
|
||
Keywords: sec508
You need to log in
before you can comment on or make changes to this bug.
Description
•