Closed
Bug 1749769
Opened 3 years ago
Closed 3 years ago
Lazy load resource transformers
Categories
(DevTools :: Framework, task)
DevTools
Framework
Tracking
(firefox98 fixed)
RESOLVED
FIXED
98 Branch
| Tracking | Status | |
|---|---|---|
| firefox98 | --- | fixed |
People
(Reporter: ochameau, Assigned: ochameau)
References
(Blocks 1 open bug)
Details
Attachments
(3 files)
ResourceCommand module currenty load all transformers upfront:
https://searchfox.org/mozilla-central/rev/83e67336083df9f9a3d1e0c33f2ba19703d57161/devtools/shared/commands/resource/resource-command.js#1199-1222
whereas we might not use all of them.
Also, loading them from jest tests introduce some exception whereas we aren't necessarily using them.
|
Assignee | |
Comment 1•3 years ago
|
||
Doing this helps load resource-command module from jest tests
which were throwing when loading the transformers.
And it probably is a small performance improvement.
|
|
Assignee | |
Comment 2•3 years ago
|
||
|
|
Assignee | |
Comment 3•3 years ago
|
||
|
|
Assignee | |
Comment 4•3 years ago
|
||
|
||
Updated•3 years ago
|
Assignee: nobody → poirot.alex
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•3 years ago
|
Assignee: nobody → poirot.alex
|
|
||
Updated•3 years ago
|
Attachment #9258860 -
Attachment description: Bug 1749769 - [devtools] Lazy load all resource legacy listeners → Bug 1749769 - [devtools] Lazy load all resource legacy listeners.
|
|
||
Updated•3 years ago
|
Attachment #9258861 -
Attachment description: Bug 1749769 - [devtools] Lazy load target legacy listeners → Bug 1749769 - [devtools] Lazy load target legacy listeners.
Pushed by apoirot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7f038064b3a2
[devtools] Lazy load all resource transformers. r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/e6ba00a49c0b
[devtools] Lazy load all resource legacy listeners. r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/698709d24aa5
[devtools] Lazy load target legacy listeners. r=nchevobbe
|
||
Comment 6•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/7f038064b3a2
https://hg.mozilla.org/mozilla-central/rev/e6ba00a49c0b
https://hg.mozilla.org/mozilla-central/rev/698709d24aa5
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox98:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 98 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•