Closed
Bug 1750070
Opened 3 years ago
Closed 3 years ago
Crash in [@ nsFrameLoader::RequestTabStateFlush]
Categories
(Core :: DOM: Navigation, defect)
Tracking
()
RESOLVED
FIXED
100 Branch
| Tracking | Status | |
|---|---|---|
| firefox-esr91 | --- | unaffected |
| firefox99 | --- | wontfix |
| firefox100 | --- | fixed |
People
(Reporter: sefeng, Assigned: sefeng)
References
(Blocks 1 open bug)
Details
(Keywords: crash)
Crash Data
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
Maybe Fission related. (DOMFissionEnabled=1)
Crash report: https://crash-stats.mozilla.org/report/index/7ab4469c-1b50-4e58-aba2-081740211204
Reason: EXCEPTION_ACCESS_VIOLATION_READ
Top 10 frames of crashing thread:
0 xul.dll nsFrameLoader::RequestTabStateFlush dom/base/nsFrameLoader.cpp:3226
1 xul.dll mozilla::dom::FrameLoader_Binding::requestTabStateFlush_promiseWrapper dom/bindings/FrameLoaderBinding.cpp:700
2 xul.dll mozilla::dom::binding_detail::GenericMethod<mozilla::dom::binding_detail::NormalThisPolicy, mozilla::dom::binding_detail::ConvertExceptionsToPromises> dom/bindings/BindingUtils.cpp:3300
3 xul.dll js::InternalCallOrConstruct js/src/vm/Interpreter.cpp:472
4 xul.dll Interpret js/src/vm/Interpreter.cpp:3239
5 xul.dll js::Call js/src/vm/Interpreter.cpp:549
6 xul.dll JS_CallFunctionValue js/src/vm/CallAndConstruct.cpp:53
7 xul.dll nsXPCWrappedJS::CallMethod js/xpconnect/src/XPCWrappedJSClass.cpp:973
8 xul.dll PrepareAndDispatch xpcom/reflect/xptcall/md/win32/xptcstubs_x86_64.cpp:168
9 xul.dll SharedStub
Looks like a nullptr crash, perhaps GetOwnerDoc() could be null?
|
Assignee | |
Comment 1•3 years ago
|
||
|
||
Updated•3 years ago
|
Assignee: nobody → sefeng
Status: NEW → ASSIGNED
|
|
||
Updated•3 years ago
|
Attachment #9258991 -
Attachment description: Bug 1750070 - Add a nullptr check for the owner document in nsFrameLoader::RequestTabStateFlush r=nika → Bug 1750070 - Use default scope in nsFrameLoader::RequestTabStateFlush r=nika
Pushed by sefeng@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f341a7779297
Use default scope in nsFrameLoader::RequestTabStateFlush r=nika
Backout by csabou@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/40a963c61248
Backed out changeset f341a7779297 for causing bc failures on browser_aboutNewTab_bookmarksToolbarPrefs.js and others. CLOSED TREE
|
||
Comment 4•3 years ago
|
||
Backed out for causing bc failures on browser_aboutNewTab_bookmarksToolbarPrefs.js and others.
Failure log:
- https://treeherder.mozilla.org/logviewer?job_id=366258746&repo=autoland
- https://treeherder.mozilla.org/logviewer?job_id=366255412&repo=autoland
- https://treeherder.mozilla.org/logviewer?job_id=366259310&repo=autoland
- https://treeherder.mozilla.org/logviewer?job_id=366260172&repo=autoland
- https://treeherder.mozilla.org/logviewer?job_id=366256405&repo=autoland
Backout link: https://hg.mozilla.org/integration/autoland/rev/40a963c61248331f06c7b02fe97fec08279d56b2
Flags: needinfo?(sefeng)
|
||
Comment 5•3 years ago
|
||
There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:sefeng, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit auto_nag documentation.
Flags: needinfo?(sefeng)
Flags: needinfo?(nika)
|
|
||
Updated•3 years ago
|
Attachment #9258991 -
Attachment description: Bug 1750070 - Use default scope in nsFrameLoader::RequestTabStateFlush r=nika → Bug 1750070 - Fix nullptr crash in nsFrameLoader::RequestTabStateFlush r=nika
Pushed by sefeng@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/49943a3a5f98
Fix nullptr crash in nsFrameLoader::RequestTabStateFlush r=nika,farre
|
||
Comment 8•3 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox100:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 100 Branch
|
||
Updated•3 years ago
|
|
||
Updated•3 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•