Closed Bug 1750504 Opened 3 years ago Closed 3 years ago

"Open in System Viewer" menuitem in downloads panel should not be available when selected download's target doesn't exist

Categories

(Firefox :: Downloads Panel, defect)

Desktop
Unspecified
defect

Tracking

()

RESOLVED FIXED
98 Branch
Tracking Status
firefox98 --- fixed

People

(Reporter: aminomancer, Assigned: aminomancer)

References

Details

Attachments

(1 file)

STR

  • Download a file
  • Open the file in your file manager
  • Delete the file
  • Open the downloads panel or all downloads view
  • Right click the download

Expected

"Open in System Viewer" should be hidden since clicking it has no effect, as the downloaded file does not exist. "Always Open in System Viewer" should be visible though.

Actual

Both menuitems are visible.

Assignee: nobody → shmediaproductions
Status: NEW → ASSIGNED

This item has actually been there for a year and a half and wasn't related to 2021's downloads improvements, see bug 1639069.

Blocks: 1631105
No longer blocks: 1744297

Oh, yeah I think I just tracked it to the blame for the line I changed, Bug 1707652

Attachment #9259343 - Attachment description: Bug 1750504 - Hide Open in System Viewer menuitem if file is missing. r?jaws → Bug 1750504 - Fix test file description. r=Gijs
Attachment #9259343 - Attachment description: Bug 1750504 - Fix test file description. r=Gijs → Bug 1750504 - Hide Open in System Viewer menuitem if file is missing. r=Gijs
Pushed by gijskruitbosch@gmail.com: https://hg.mozilla.org/integration/autoland/rev/274729e3eca1 Hide Open in System Viewer menuitem if file is missing. r=Gijs
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 98 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: