Closed
Bug 1750576
Opened 3 years ago
Closed 2 years ago
Expose WebGPU shader compilation info
Categories
(Core :: Graphics: WebGPU, enhancement)
Core
Graphics: WebGPU
Tracking
()
RESOLVED
FIXED
104 Branch
| Tracking | Status | |
|---|---|---|
| firefox104 | --- | fixed |
People
(Reporter: kvark, Assigned: nical)
References
(Regressed 1 open bug)
Details
Attachments
(3 files)
|
(deleted),
patch
|
Details | Diff | Splinter Review | |
|
(deleted),
text/x-phabricator-request
|
Details | |
|
(deleted),
text/x-phabricator-request
|
Details |
We need to expose the shader compilation info. Currently our WebIDL has it commented out:
interface GPUShaderModule {
//TODO:
//Promise<GPUCompilationInfo> compilationInfo();
};
|
Reporter | |
Updated•3 years ago
|
|
||
Updated•3 years ago
|
|
|
Reporter | |
Comment 1•3 years ago
|
||
My unfinished patch for this
|
Assignee | |
Comment 2•2 years ago
|
||
|
||
Updated•2 years ago
|
Assignee: nobody → nical.bugzilla
Attachment #9277309 -
Attachment description: WIP: Bug 1750576 - (WIP) WebGPU shader module compilationInfo → Bug 1750576 - WebGPU shader module asynchronous CompilationInfo API. r=aosmond,jimb
Status: NEW → ASSIGNED
|
|
||
Updated•2 years ago
|
Attachment #9277309 -
Attachment description: Bug 1750576 - WebGPU shader module asynchronous CompilationInfo API. r=aosmond,jimb → Bug 1750576 - WebGPU shader module asynchronous CompilationInfo API. r=jimb,emilio
|
|
Assignee | |
Comment 3•2 years ago
|
||
Inspired by emilio's suggestion in the shader module API patch. This tries to be the most straightforward way to go from the strings coming from IPC to the ones consumed by wgpu.
Pushed by nsilva@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0a2e3c4ca14f
WebGPU shader module asynchronous CompilationInfo API. r=aosmond,emilio
|
||
Comment 5•2 years ago
|
||
Backed out for bustages on RefPtr
Backout link: https://hg.mozilla.org/integration/autoland/rev/28d4584450219a70fcd6d6dd5edda54459a68353
Log link: https://treeherder.mozilla.org/logviewer?job_id=383514842&repo=autoland&lineNumber=33399
Flags: needinfo?(nical.bugzilla)
Pushed by nsilva@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/be7493c6f3cb
WebGPU shader module asynchronous CompilationInfo API. r=aosmond,emilio
https://hg.mozilla.org/integration/autoland/rev/21ede22c4113
Avoid passing raw strings in a couple of wgpu bindings entry points. r=emilio
|
||
Comment 7•2 years ago
|
||
Backed out for causing lint failures and build bustages
- Backout link
- Push with failures
- Failure Log Bustages
- Failure line: /builds/worker/workspace/obj-build/dist/include/mozilla/webgpu/WebGPUTypes.h:48:3: error: bad implicit conversion constructor for 'StringHelper'.
- Failure Log lint
Pushed by nsilva@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/50901e1befca
WebGPU shader module asynchronous CompilationInfo API. r=aosmond,emilio
https://hg.mozilla.org/integration/autoland/rev/807e95cd9956
Avoid passing raw strings in a couple of wgpu bindings entry points. r=emilio
|
|
Assignee | |
Updated•2 years ago
|
Flags: needinfo?(nical.bugzilla)
|
||
Comment 9•2 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/50901e1befca
https://hg.mozilla.org/mozilla-central/rev/807e95cd9956
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox104:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 104 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•