Enable win32k lockdown by default in Nightly
Categories
(Core :: Security: Process Sandboxing, task, P1)
Tracking
()
Tracking | Status | |
---|---|---|
firefox99 | --- | fixed |
People
(Reporter: evilpie, Assigned: cmartin)
References
(Blocks 1 open bug)
Details
(Keywords: perf-alert)
Attachments
(2 files)
Reporter | ||
Updated•3 years ago
|
Reporter | ||
Updated•3 years ago
|
Updated•3 years ago
|
Assignee | ||
Comment 1•3 years ago
|
||
It's time to graduate Win32k lockdown from Nightly Experiments to default on
Nightly.
Comment 3•3 years ago
|
||
Backed out changeset 052d3687f4f0 (Bug 1750742) for causing marionette test failures.
Backout link
Push with failures
Failure Log
Comment 4•3 years ago
|
||
Try push with (hopefully) fixed enabled by default tests:
https://treeherder.mozilla.org/jobs?repo=try&revision=469b69c6bdddd8be968bfea038af1e2a6b284017
Comment 5•3 years ago
|
||
This also changes gen_win32k_tests.py to work on Windows.
Updated•3 years ago
|
Comment 6•3 years ago
|
||
(In reply to Bob Owen (:bobowen) from comment #4)
Try push with (hopefully) fixed enabled by default tests:
https://treeherder.mozilla.org/jobs?repo=try&revision=469b69c6bdddd8be968bfea038af1e2a6b284017
I've fixed the lint error (single quotes in gen script).
Assignee | ||
Updated•3 years ago
|
Comment 8•3 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/9ab08f172d80
https://hg.mozilla.org/mozilla-central/rev/cfc475962a9e
Comment 9•3 years ago
|
||
(In reply to Marian-Vasile Laza from comment #3)
Backed out changeset 052d3687f4f0 (Bug 1750742) for causing marionette test failures.
Backout link
Push with failures
Failure Log
== Change summary for alert #33418 (as of Tue, 01 Mar 2022 11:41:51 GMT) ==
Improvements:
Ratio | Test | Platform | Options | Absolute values (old vs new) |
---|---|---|---|---|
15% | cpstartup content-process-startup | windows10-64-shippable-qr | e10s fission stylo webrender-sw | 69.46 -> 58.83 |
15% | cpstartup content-process-startup | windows10-64-shippable-qr | e10s fission stylo webrender | 70.12 -> 59.92 |
11% | cpstartup content-process-startup | windows10-64-shippable-qr | e10s fission stylo webrender | 67.07 -> 59.42 |
For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=33418
Comment 10•3 years ago
|
||
(In reply to Alex Finder from comment #9)
For clarity was it the back-out or the re-landing that caused the improvement?
Comment 11•3 years ago
|
||
(In reply to Bob Owen (:bobowen) from comment #10)
(In reply to Alex Finder from comment #9)
For clarity was it the back-out or the re-landing that caused the improvement?
Between 9ab08f172d80 and cfc475962a9e, it was revision cfc475962a9e that caused the improvement (corresponding to patch D139487 ). Upon initial post, I thought it was related to the backout, but I can't find that revision in the backout link. So I suspect it's from the re-landing. Sorry for the confusion!
Updated•3 years ago
|
Description
•