Closed
Bug 1750998
Opened 3 years ago
Closed 3 years ago
Enable loading site-specific video wrapper scripts on debug builds
Categories
(Toolkit :: Picture-in-Picture, task, P1)
Toolkit
Picture-in-Picture
Tracking
()
RESOLVED
FIXED
98 Branch
| Tracking | Status | |
|---|---|---|
| firefox98 | --- | fixed |
People
(Reporter: mtigley, Assigned: mtigley)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
After Bug 1670108, it will now be possible to write site-specific adapter scripts for Picture-in-Picture. Unfortunately, this functionality is only available for Nightly and non-debug builds since loading a site-specific script will cause the originating PiP tab to crash otherwise (see Bug 1749819).
Due to this, we shouldn't try shipping this functionality to release since debug builds can help us detect potential security holes and memory leaks that wouldn't otherwise be reported on a non-debug one.
Once Bug 1749819 has been resolved, we can remove these checks and allow site-specific functionality to work on debug builds and ship to release.
EDIT: Enabling site-specific wrappers on release will be addressed in bug 1751793.
|
Assignee | |
Updated•3 years ago
|
Summary: Remove checks that prevent loading site-specific wrapper scripts on debug and Nightly builds → Remove checks that prevent loading site-specific wrapper scripts on debug and non-Nightly builds
|
|
Assignee | |
Comment 1•3 years ago
|
||
|
||
Updated•3 years ago
|
Assignee: nobody → mtigley
Status: NEW → ASSIGNED
|
||
Updated•3 years ago
|
Severity: -- → N/A
Priority: -- → P1
|
|
Assignee | |
Updated•3 years ago
|
Summary: Remove checks that prevent loading site-specific wrapper scripts on debug and non-Nightly builds → Enable loading site-wrapper video scripts on debug builds
|
|
Assignee | |
Updated•3 years ago
|
Summary: Enable loading site-wrapper video scripts on debug builds → Enable loading site-specific video wrapper scripts on debug builds
Pushed by mtigley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8bec4c378ff6
Enable loading site-specific wrapper scripts on debug builds. r=mhowell
|
||
Comment 3•3 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox98:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 98 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•