Closed Bug 1751154 Opened 3 years ago Closed 3 years ago

Consistent error handling for frameIds parameter in scripting API

Categories

(WebExtensions :: General, enhancement, P2)

Product:
WebExtensions
Component:
General
Type:
enhancement

Tracking

(firefox98 fixed)

Status:
RESOLVED FIXED
Milestone:
98 Branch
Tracking Flags:
Tracking Status
firefox98 --- fixed

People

(Reporter: willdurand, Assigned: willdurand)

References

(Blocks 1 open bug)

Details

(Whiteboard: [addons-jira])

Attachments

(1 file)

Bug 1751154 - More consistent error handling for frameIds parameter in scripting API. r?robwu!
(deleted), text/x-phabricator-request
Details
Blocks: 1735474
Blocks: 1739643
Assignee: nobody → wdurand
Whiteboard: [addons-jira]
Severity: -- → S2
Priority: -- → P2
Severity: S2 → N/A
Pushed by wdurand@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7ba91106687b More consistent error handling for frameIds parameter in scripting API. r=robwu

Backed out for causing mochitest failures on test_ext_tabs_executeScript.html

Backout link

Push with failures

Failure log for 3 // Failure log for bc

Failure line(s): TEST-UNEXPECTED-FAIL | mobile/android/components/extensions/test/mochitest/test_ext_tabs_executeScript.html | Got expected error - Expected: Frame not found, or missing host permission, Actual: Invalid frame IDs: [9007199254740991] // TEST-UNEXPECTED-FAIL | browser/components/extensions/test/browser/browser_ext_tabs_executeScript.js | Got expected error - Expected: Frame not found, or missing host permission, Actual: Invalid frame IDs: [9007199254740991]. -

Flags: needinfo?(wdurand)

oops, OK I didn't update these tests in the previous patch, sorry about that. I pushed a new revision and will autoland it when it gets approved.

Flags: needinfo?(wdurand)
Pushed by wdurand@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ea7413cc34b5 More consistent error handling for frameIds parameter in scripting API. r=robwu

https://hg.mozilla.org/mozilla-central/rev/ea7413cc34b5

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox98: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 98 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: