Open Bug 1751244 Opened 3 years ago Updated 2 years ago

PiP enabled/disabled probe needs tests for telemetry events

Categories

(Toolkit :: Picture-in-Picture, task, P3)

task

Tracking

()

People

(Reporter: kpatenio, Unassigned)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [fidefe-pip3])

In bug 1639774, we added telemetry probes to detect whenever Picture in Picture is enabled or disabled.

We currently test for scalar changes. However, we are missing tests for telemetry events whenever the pref media.videocontrols.picture-in-picture.video-toggle.enabled is toggled. (Missed this in my review. My bad!)

Having these tests can ensure that we are recording events as expected.
(testing events documentation). We also have existing tests for telemetry that can be used as reference.

Severity: -- → N/A
Priority: -- → P3
Blocks: 1751505

Right now there is a severe frequency of failures for the test browser_telemetry_togglePiP.js (see Bug 1755274).
I think we should hold off from modifying the test until we can determine the reason for the sudden spike in failures.

Depends on: 1755274
Blocks: 1772335
No longer blocks: 1772335
Assignee: nobody → bnasar
Whiteboard: [fidefe-pip3]
Assignee: bnasar → nobody
You need to log in before you can comment on or make changes to this bug.