Invocation of certutil can fail because of invalid library path (from binary instead of certutil binary)
Categories
(Testing :: web-platform-tests, defect, P3)
Tracking
(firefox98 fixed)
| Tracking | Status | |
|---|---|---|
| firefox98 | --- | fixed |
People
(Reporter: whimboo, Assigned: whimboo)
References
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
The invocation of certutil can fail for wdspec jobs in CI:
https://treeherder.mozilla.org/jobs?repo=try&revision=e2f70f7747d344e5dda134f822b9d3179664d393
[task 2022-01-11T21:42:14.543Z] 21:42:14 CRITICAL - subprocess.CalledProcessError: Command '['/builds/worker/workspace/build/hostutils/host-utils-93.0a1.en-US.linux-x86_64/certutil', '-N', '-d', '/tmp/tmprfyom2sb.mozrunner', '-f', '/tmp/tmprfyom2sb.mozrunner/.crtdbpw']' returned non-zero exit status 1.
[task 2022-01-11T21:42:14.745Z] 21:42:14 ERROR - Return code: 1
The reason for that is whenever a binary is passed-in to mach wpt the following code takes the Library path based on the binarie's directory instead of the explicitly stated certutils directory:
certutil_dir = os.path.dirname(self.binary or self.certutil_binary)
To fix that we should always use the directory of the certutil binary if specified, and if not fallback to the binary.
|
Assignee | |
Comment 1•3 years ago
|
||
|
||
Updated•3 years ago
|
Pushed by hskupin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a988f9123b0d [wptrunner] Don't pass binary path in mozharness script when on Android. r=jgraham
|
||
Comment 3•3 years ago
|
||
| bugherder | ||
Description
•