Closed
Bug 1752143
Opened 3 years ago
Closed 3 years ago
test_refresh_firefox.py uses SSWindowStateReady event to check that session is restored,
Categories
(Firefox :: Migration, defect, P3)
Firefox
Migration
Tracking
()
RESOLVED
FIXED
101 Branch
| Tracking | Status | |
|---|---|---|
| firefox101 | --- | fixed |
People
(Reporter: farre, Assigned: farre)
References
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
test_refresh_firefox.py uses SSWindowStateReady event to check that session is restored, but then looks at currentURI to confirm that the right page is loaded.
Trouble is that when SSWindowStateReady fire, due to the browser's being RemoteWebNavigation and may not have the correct currentURI yet, the test fail. We need to wait for currentURI to update, which happens in onLocationChange.
|
Assignee | |
Updated•3 years ago
|
Assignee: nobody → afarre
|
|
Assignee | |
Comment 1•3 years ago
|
||
|
||
Updated•3 years ago
|
Severity: -- → S3
Priority: -- → P3
|
||
Comment 2•3 years ago
|
||
There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:farre, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit auto_nag documentation.
Flags: needinfo?(gijskruitbosch+bugs)
Flags: needinfo?(afarre)
|
||
Comment 3•3 years ago
|
||
I assume this is ready to land, but Andreas can confirm.
Flags: needinfo?(gijskruitbosch+bugs)
|
||
Updated•3 years ago
|
Attachment #9260868 -
Attachment description: Bug 1752143 - Wait for onLocationChange before checking test result. r=Gijs → Bug 1752143 - Wait for SSTabRestored before checking test result. r=Gijs
Pushed by afarre@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b467cb691839
Wait for SSTabRestored before checking test result. r=Gijs
|
||
Comment 5•3 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox101:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 101 Branch
|
|
Assignee | |
Updated•2 years ago
|
Flags: needinfo?(afarre)
You need to log in
before you can comment on or make changes to this bug.
Description
•