Closed Bug 1752412 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 32575 - Handle "infinitely" tall content when column-balancing.

Categories

(Core :: Layout: Columns, task, P4)

Product:
Core
Component:
Layout: Columns
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
99 Branch
Tracking Flags:
Tracking Status
firefox99 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(Depends on 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 32575 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/32575
Details from upstream follow.

Morten Stenshorne <mstensho@chromium.org> wrote:

Handle "infinitely" tall content when column-balancing.

When calculating the initial column block-size during column balancing,
don't include previously consumed block-size in fragmentainer size
calculation (only to subtract it again later), and leave max block-size
alone if it's 'none'.

We had trouble with very tall content, because we ended up with
LayoutUnit::Max() and then subtracted something, ending up with a
different result. Just don't add and then subtract the same amount, so
that we get the right result.

Bug: 1289800
Change-Id: I7df6339c776206807af8beca527d3e95d96d37e6
Reviewed-on: https://chromium-review.googlesource.com/3421427
WPT-Export-Revision: c84800271e14c4a4062fa3ce3afb170db9c43805

Component: web-platform-tests → Layout: Columns
Product: Testing → Core
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/40a5bbc81ada [wpt PR 32575] - Handle "infinitely" tall content when column-balancing., a=testonly
Test result changes from PR not available.
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3d9d13476532 [wpt PR 32575] - Handle "infinitely" tall content when column-balancing., a=testonly
Test result changes from PR not available.

https://hg.mozilla.org/mozilla-central/rev/3d9d13476532

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox99: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 99 Branch
You need to log in before you can comment on or make changes to this bug.