Closed Bug 1752523 Opened 3 years ago Closed 3 years ago

Regressing html select dropdown issues

Categories

(GeckoView :: General, defect)

Firefox 98
Unspecified
All
defect

Tracking

(firefox-esr91 unaffected, firefox96 unaffected, firefox97 unaffected, firefox98 fixed)

RESOLVED FIXED
98 Branch
Tracking Status
firefox-esr91 --- unaffected
firefox96 --- unaffected
firefox97 --- unaffected
firefox98 --- fixed

People

(Reporter: anastasiostam, Assigned: emilio)

References

(Regression)

Details

(Keywords: regression)

Attachments

(2 files)

Followup of issues #1752133 and #1751674
The major problem is fixed, some minor problems remain:

  1. If you tap on the <select> element and then tap on the empty part of the screen, the popup closes. To reopen the dropdown, you need to tap on the element twice (like 1752133)

  2. If the single select element has the "size" attribute, the element is unclickable

Both of these work in the latest stable version

Depends on: 1752133, 1751674
Keywords: regression
Regressed by: 1750395

Set release status flags based on info from the regressing bug 1750395

Has Regression Range: --- → yes

Tagging Emilio who fixed 1752133 and 1751674

Flags: needinfo?(emilio)

Are you sure you're using a Gecko version with the fix for bug 1752133? Fenix doesn't update Gecko so frequently.

Fenix Nightly has GV 98.0a1-20220127094620 (the hg details say it has the bug 1752133 fix)
There if you click on the <select> and select an option from the popup, it works fine. (Next time you click the element it opens again the popup)
However if the <select> is clicked and no option is selected (click back button or blank part of screen), next time 2 clicks are needed.

I also built the GV Example Browser, where the above issue is not happening.

In both cases however, if the select element has the "size" attribute, the popup doesn't appear at all.

There are two things that make an element not be a combobox:

  • <select multiple>
  • <select size=N> where N > 1

I was only handling the former. Expose the gecko-internal method we have
for this via WebIDL to get this fully right forever.

The other issue reported in this bug is not a GeckoView issue, it's an
android-components issue, will file / maybe fix there if I figure out
how.

Assignee: nobody → emilio

Thanks, yeah. So the first one was a mistake on my side. I assumed !combobox == multiple and that's clearly not true. Comment 5 fixes that. The other issue is with android-components, will file there.

Thanks so much!

Flags: needinfo?(emilio)
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ce0468b4f920 Fix handling of non-multiple <select> with size >1. r=agi
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 98 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: