Closed Bug 1752560 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 32594 - [PaymentHandler] Fix crash in PaymentInstruments.set

Categories

(Core :: DOM: Web Payments, task, P4)

task

Tracking

()

RESOLVED FIXED
99 Branch
Tracking Status
firefox99 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(Depends on 1 open bug, )

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 32594 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/32594
Details from upstream follow.

Stephen McGruer <smcgruer@chromium.org> wrote:

[PaymentHandler] Fix crash in PaymentInstruments.set

The code was accessing both 'type' and 'sizes' for an icon definition
without checking if they were set. Provide defaults to both to avoid a
crash.

Bug: None
Change-Id: Ibcf056dbe6ee9be1c8582e799bad41f367af9b5c
Reviewed-on: https://chromium-review.googlesource.com/3424308
WPT-Export-Revision: 309e735bb35f843b2f1bec76be3402244e0158af

Component: web-platform-tests → DOM: Web Payments
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 19 subtests

Status Summary

Firefox

OK : 1
FAIL : 19

Chrome

CRASH: 1

Safari

OK : 1
FAIL : 19

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/payment-handler/payment-instruments.https.html
Instrument keys are returned in the original insertion order: FAIL (Safari: FAIL)
Deleting an existing instrument returns true: FAIL (Safari: FAIL)
Deleting an existing instrument the second time returns false: FAIL (Safari: FAIL)
Deleting a non-existing instrument returns false: FAIL (Safari: FAIL)
Getting an existing instrument returns the instrument: FAIL (Safari: FAIL)
Getting a non-existing instrument returns undefined: FAIL (Safari: FAIL)
Resetting an existing instrument updates the instrument: FAIL (Safari: FAIL)
Clearing the instruments: FAIL (Safari: FAIL)
Cannot register instruments with invalid icon media type image/jif: FAIL (Safari: FAIL)
Don't crash when registering instruments with very long icon media type image/pngggggg...: FAIL (Safari: FAIL)
Don't crash when registering an instrument with a very long icon size 888...x888...: FAIL (Safari: FAIL)
Don't crash when 'sizes' missing from icon definition: FAIL (Safari: FAIL)
Don't crash when 'type' missing from icon definition: FAIL (Safari: FAIL)
Cannot register instruments with invalid icon size "256 256" (missing "x"): FAIL (Safari: FAIL)
Cannot register instruments with invalid icon URL (has a null character): FAIL (Safari: FAIL)
Cannot register instruments with non-existing non-https icon URL: FAIL (Safari: FAIL)
Cannot register instruments with an existing non-https icon URL: FAIL (Safari: FAIL)
Don't crash on very long key, name, method, and capability strings.: FAIL (Safari: FAIL)
Don't crash on null characters in key, name, method, and capability strings.: FAIL (Safari: FAIL)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5e6dc08fedae [wpt PR 32594] - [PaymentHandler] Fix crash in PaymentInstruments.set, a=testonly
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/fea6f44feb5e [wpt PR 32594] - [PaymentHandler] Fix crash in PaymentInstruments.set, a=testonly
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 99 Branch
You need to log in before you can comment on or make changes to this bug.