Closed
Bug 1753515
Opened 3 years ago
Closed 3 years ago
Add a basic test for scriptworker.py in Gecko
Categories
(Developer Infrastructure :: Try, task)
Developer Infrastructure
Try
Tracking
(firefox99 fixed)
RESOLVED
FIXED
99 Branch
| Tracking | Status | |
|---|---|---|
| firefox99 | --- | fixed |
People
(Reporter: ahal, Assigned: ahal)
References
Details
Attachments
(2 files)
No description provided.
|
Assignee | |
Updated•3 years ago
|
Component: General → Try
Product: Release Engineering → Firefox Build System
QA Contact: aki
|
|
Assignee | |
Comment 1•3 years ago
|
||
Some try selectors (like 'release' or 'scriptworker') depend on modifying
source files to work. Normally, these changes will be committed into the
temporary commit that the 'hg push-to-try' extension makes.
But if the --no-push flag is specified, these changes will be left lying around
in the sourcedir. This ensures we don't modify anything when '--no-push' is
used.
|
|
Assignee | |
Comment 2•3 years ago
|
||
These tests aren't very comprehensive, but should catch simple mistakes like
ImportErrors.
Depends on D137806
|
||
Updated•3 years ago
|
Attachment #9262202 -
Attachment description: Bug 1753515 - [tryselect] Add a basic tests for releaseand scriptworker selectors, r?#releng-reviewers! → Bug 1753515 - [tryselect] Add a basic tests for release and scriptworker selectors, r?#releng-reviewers!
|
|
||
Updated•3 years ago
|
Attachment #9262202 -
Attachment description: Bug 1753515 - [tryselect] Add a basic tests for release and scriptworker selectors, r?#releng-reviewers! → Bug 1753515 - [tryselect] Add a basic tests for releaseand scriptworker selectors, r?#releng-reviewers!
Pushed by ahalberstadt@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4d27e27d1a56
[tryselect] Don't modify 'files_to_change' when --no-push selected, r=releng-reviewers,jmaher
https://hg.mozilla.org/integration/autoland/rev/5cd93e7a76fd
[tryselect] Add a basic tests for releaseand scriptworker selectors, r=releng-reviewers,jcristau
|
||
Comment 4•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/4d27e27d1a56
https://hg.mozilla.org/mozilla-central/rev/5cd93e7a76fd
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox99:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 99 Branch
|
||
Updated•2 years ago
|
Product: Firefox Build System → Developer Infrastructure
You need to log in
before you can comment on or make changes to this bug.
Description
•