Closed Bug 1754450 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 32771 - [@container] Support nested @container rules

Categories

(Core :: Layout, task, P4)

Product:
Core
Component:
Layout
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
99 Branch
Tracking Flags:
Tracking Status
firefox99 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(Depends on 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 32771 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/32771
Details from upstream follow.

Anders Hartvoll Ruud <andruud@chromium.org> wrote:

[@container] Support nested @container rules

To support nested @container rules, we store a parent pointer on
ContainerQuery itself, and populate this pointer during
RuleSet::AddChildRules.

This is not the theoretically most efficient solution if there is
heavy nesting, but it's a relatively simple approach which keeps the
non-nested case relatively lightweight.

ElementRuleCollector then traverses these parent pointers while
effectively AND-ing the results together.

Fixed: 1219422
Change-Id: If535561f95b4f97cf0a468fe09b40cb0bc772aa5
Reviewed-on: https://chromium-review.googlesource.com/3449221
WPT-Export-Revision: 3b8e6cd3d2e7314e1260668ab6b1e0bbee98297f

Component: web-platform-tests → Layout
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

ERROR: 1

Chrome

ERROR: 1

Safari

ERROR: 1

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-contain/container-queries/container-nested.html: ERROR (Chrome: ERROR, Safari: ERROR)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b55a9d55757c [wpt PR 32771] - [@container] Support nested @container rules, a=testonly https://hg.mozilla.org/integration/autoland/rev/2f0ecf2c61ca [wpt PR 32771] - Update wpt metadata, a=testonly
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b7d791786f2d [wpt PR 32771] - [@container] Support nested @container rules, a=testonly https://hg.mozilla.org/integration/autoland/rev/1085358daf78 [wpt PR 32771] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/b7d791786f2d
https://hg.mozilla.org/mozilla-central/rev/1085358daf78

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox99: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 99 Branch
You need to log in before you can comment on or make changes to this bug.