Closed
Bug 1754453
Opened 3 years ago
Closed 3 years ago
Speed up getWarningGroupType
Categories
(DevTools :: Console, task)
DevTools
Console
Tracking
(firefox99 fixed)
RESOLVED
FIXED
99 Branch
| Tracking | Status | |
|---|---|---|
| firefox99 | --- | fixed |
People
(Reporter: nchevobbe, Assigned: nchevobbe)
Details
(Whiteboard: dt-console-perf-2022 )
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
The function does show up in profile and it seems like we could cut some of the time spent there
|
Assignee | |
Comment 1•3 years ago
|
||
If the message isn't a warning or an info, it can't
be in a warningGroup, so we can exit the function
earlier and avoid useless checks.
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f0c852c7bc3f
[devtools] Early exit getWarningGroupType when message can't be in a warningGroup. r=dthayer.
|
||
Comment 3•3 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox99:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 99 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•