Closed
Bug 1755536
Opened 3 years ago
Closed 3 years ago
Cover breakable position reducer data extensively with a test
Categories
(DevTools :: Debugger, task)
DevTools
Debugger
Tracking
(firefox99 fixed)
RESOLVED
FIXED
99 Branch
| Tracking | Status | |
|---|---|---|
| firefox99 | --- | fixed |
People
(Reporter: ochameau, Assigned: ochameau)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
This data is quite complex to compute and we able almost no test against this.
One reason is that it isn't easily testable.
This data is used for breakpoints management (shifting and sourcemap updates),
but also for setting column breakpoints.
Column breakpoints are using Codemirror markers, which aren't trivial to test.
This data is computed from here:
https://searchfox.org/mozilla-central/rev/94d7c959115c03ea1e9406d6105b36cabe63775d/devtools/client/debugger/src/actions/breakpoints/breakpointPositions.js#113-195
|
Assignee | |
Comment 1•3 years ago
|
||
This test doesn't ensure we correctly hit the column breakpoints, but rather focus on
asserting that we display and update the column breakpoints options correctly.
That, especially when the source content change across reloads.
Pushed by apoirot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/75d823545b2d
[devtools] Cover breakable columns data extensively. r=bomsy
|
||
Comment 3•3 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox99:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 99 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•