Open
Bug 1755889
Opened 3 years ago
Updated 2 years ago
'unused variable' build errors when building without MOZ_GECKO_PROFILER
Categories
(Core :: Gecko Profiler, defect, P3)
Core
Gecko Profiler
Tracking
()
NEW
People
(Reporter: florian, Unassigned)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file)
|
(deleted),
patch
|
Details | Diff | Splinter Review |
When trying to push to try builds with MOZ_GECKO_PROFILER to debug bug 1755450, I encountered a few other build errors due to unused variables and -Werror,-Wunused-variable that I had to workaround to verify my patch.
I'm attaching the workaround that I used. I think it's correct for the security/sandbox/linux/SandboxFilter.cpp change, but for tools/profiler/public/GeckoTraceEvent.h it might be better to define the non-MOZ_GECKO_PROFILER version of MOZ_INTERNAL_UPROFILER_SIMPLE_EVENT in a way that would (void) all parameters.
|
||
Updated•3 years ago
|
Has Regression Range: --- → yes
|
|
||
Updated•3 years ago
|
Keywords: regression
Severity: -- → S3
Priority: -- → P3
|
||
Updated•2 years ago
|
Severity: S3 → N/A
|
|
||
Updated•2 years ago
|
Severity: N/A → S4
You need to log in
before you can comment on or make changes to this bug.
Description
•