Closed Bug 1755976 Opened 3 years ago Closed 3 years ago

Add support for `css` in `scripting.RegisteredContentScript`

Categories

(WebExtensions :: General, enhancement, P2)

enhancement
Points:
1

Tracking

(firefox100 fixed)

RESOLVED FIXED
100 Branch
Tracking Status
firefox100 --- fixed

People

(Reporter: willdurand, Assigned: willdurand)

References

Details

(Whiteboard: [addons-jira])

Attachments

(1 file)

It's about adding support for css and writing tests. This should be very similar to what has been done for js.

We'll have to make sure runAt is not taken into account for css, see: https://bugzilla.mozilla.org/show_bug.cgi?id=1755978#c1

(In reply to William Durand [:willdurand] from comment #1)

We'll have to make sure runAt is not taken into account for css, see: https://bugzilla.mozilla.org/show_bug.cgi?id=1755978#c1

This does not look like an easy task because we only have 1 runAt for both JS and CSS paths: https://searchfox.org/mozilla-central/rev/61c6b2ca66b8fc7d82a71d6f045871e5a8649cbb/dom/chrome-webidl/WebExtensionContentScript.webidl#146-184. Changing this will be done in a separate bug.

Attachment #9267193 - Attachment description: WIP: Bug 1755976 - Add support for `css` in `scripting.RegisteredContentScript`. r?robwu! → Bug 1755976 - Add support for `css` in `scripting.RegisteredContentScript`. r?robwu!
Blocks: 1759117

(In reply to William Durand [:willdurand] from comment #2)

(In reply to William Durand [:willdurand] from comment #1)

We'll have to make sure runAt is not taken into account for css, see: https://bugzilla.mozilla.org/show_bug.cgi?id=1755978#c1

This does not look like an easy task because we only have 1 runAt for both JS and CSS paths: https://searchfox.org/mozilla-central/rev/61c6b2ca66b8fc7d82a71d6f045871e5a8649cbb/dom/chrome-webidl/WebExtensionContentScript.webidl#146-184. Changing this will be done in a separate bug.

I filed Bug 1759117 for that.

Pushed by wdurand@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b3303ed44134 Add support for `css` in `scripting.RegisteredContentScript`. r=robwu
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 100 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: