Closed
Bug 1756468
Opened 3 years ago
Closed 3 years ago
Make gfxFont instances safe for use from worker threads
Categories
(Core :: Layout: Text and Fonts, defect)
Core
Layout: Text and Fonts
Tracking
()
RESOLVED
FIXED
100 Branch
| Tracking | Status | |
|---|---|---|
| firefox100 | --- | fixed |
People
(Reporter: jfkthame, Assigned: jfkthame)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
This mainly means ensuring that the gfxShapedWord cache attached to gfxFont instances, as well as any other cached state such as character coverage, is accessed/updated safely.
|
||
Updated•3 years ago
|
Severity: -- → S3
|
Assignee | |
Comment 1•3 years ago
|
||
We protect the shaped-word cache in each font with a RWLock, so that multiple threads can
shape in parallel using cached data; only when a new entry needs to be cached will we need
to take a write lock.
(To improve clarity, this patch also constifys a bunch of methods that do not mutate the
font instance.)
Depends on D141472
|
||
Updated•3 years ago
|
Assignee: nobody → jfkthame
Status: NEW → ASSIGNED
Pushed by jkew@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f26f836c1575
Add locking to gfxFont, to allow worker threads to do text shaping. r=lsalzman
|
||
Comment 3•3 years ago
|
||
Backed out for causing leakes.
Backout link: https://hg.mozilla.org/integration/autoland/rev/31c9984ea99d16b456ccf7ef8f939ff26f0de619
Failure log: https://treeherder.mozilla.org/logviewer?job_id=372138874&repo=autoland&lineNumber=7606
Flags: needinfo?(jfkthame)
Pushed by jkew@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/491217cd470c
Add locking to gfxFont, to allow worker threads to do text shaping. r=lsalzman
|
||
Comment 5•3 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox100:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 100 Branch
|
|
Assignee | |
Updated•3 years ago
|
Flags: needinfo?(jfkthame)
You need to log in
before you can comment on or make changes to this bug.
Description
•