Closed Bug 1756655 Opened 3 years ago Closed 3 years ago

Remove preprocessing conditionals from UA sheets

Categories

(Core :: CSS Parsing and Computation, task, P3)

Product:
Core
Component:
CSS Parsing and Computation
Platform:
Desktop
All
Type:
task
Points:
2

Tracking

()

Status:
RESOLVED FIXED
Milestone:
100 Branch
Tracking Flags:
Tracking Status
firefox99 --- wontfix
firefox100 --- fixed

People

(Reporter: Gijs, Assigned: sclements)

References

Details

(Whiteboard: [fidefe-2022-mr1-css-linting])

Attachments

(1 file)

Bug 1756655 - Remove ifdefs from UA style sheets r=emilio
(deleted), text/x-phabricator-request
Details

These sheets: https://searchfox.org/mozilla-central/search?q=%25if&path=layout**css&case=false&regexp=false

layout/style/res/forms.css
layout/style/res/html.css
layout/style/res/scrollbars.css
layout/style/res/ua.css

have some platform-specific checks for android/windows/macOS etc. They can all be replaced with the relevant media queries.

Assignee: nobody → sclements
Status: NEW → ASSIGNED
Attachment #9266256 - Attachment description: Bug 1756655 - Remove ifdefs from UA style sheets → Bug 1756655 - Remove ifdefs from UA style sheets r=emilio
Pushed by sclements@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/cd50b8570bd8 Remove ifdefs from UA style sheets r=emilio

Backed out for causing mochitest failures on browser_parsable_css.js

  • Backout link
  • Push with failures
  • Failure Log
  • Failure line: TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_parsable_css.js | Got error message for resource://gre-resources/html.css: Unexpected token ‘not(’ in media list
Flags: needinfo?(sclements)

Sorry about that! Fixing a typo caused that test to pass locally.

Flags: needinfo?(sclements)
Pushed by sclements@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/80346599cb61 Remove ifdefs from UA style sheets r=emilio

https://hg.mozilla.org/mozilla-central/rev/80346599cb61

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox100: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 100 Branch
Component: General → CSS Parsing and Computation
Product: Toolkit → Core
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: