Open Bug 1756749 Opened 3 years ago Updated 2 years ago

Static analysis should be able to check if an implementation is missing a QI for an interface it inherits

Categories

(Developer Infrastructure :: Source Code Analysis, enhancement, P2)

Product:
Developer Infrastructure
Component:
Source Code Analysis
Type:
enhancement

Tracking

(Not tracked)

People

(Reporter: valentin, Unassigned)

References

Details

The fix for bug 1730852 was just one line, but diagnosing it was painful.
This is a mistake I've made a few times myself: extend nsI interface and implement all the methods, but then forget to update the QI/NS_IMPL_ISUPPORTS list, so the object doesn't actually QI to that interface 🤦‍♂️

It would be nice to have a static analysis/linter to catch this, but I'm not sure how difficult it is to write one.

Severity: -- → S2
Priority: -- → P2
Product: Firefox Build System → Developer Infrastructure
You need to log in before you can comment on or make changes to this bug.