Closed Bug 1756879 Opened 3 years ago Closed 2 years ago

Selecting multiple contacts in new Address Book continues to show only the first selected contact (and inconsistency between downwards vs. upwards Shift-selection) - should show blank preview or summary/actions for selected contacts

Categories

(Thunderbird :: Address Book, defect)

Thunderbird 99
defect

Tracking

(thunderbird_esr102 fixed)

RESOLVED FIXED
103 Branch
Tracking Status
thunderbird_esr102 --- fixed

People

(Reporter: thomas8, Assigned: u695164)

References

(Blocks 1 open bug)

Details

(Keywords: regression, ux-error-prevention, ux-mode-error, Whiteboard: [Fixed by bug 1774096])

Seen on new Address Book in 99.0a1 (2022-02-23) (64-bit), Win10.

  • Selecting a single contact shows that contact in the preview pane. Good.
  • Selecting multiple adjacent contacts downwards with Shift+Arrow-down continues to show only the first selected contact - should at least show blank preview as before, or some smart summary and/or actions for selected contacts (which would probably be for another bug). This is irritating because the preview still wrongly suggests that only one contact is selected, which may lead to errors e.g. of deletion for non-adjacent contacts selected with Ctrl+Click and possibly out of view (ux-mode-error).
  • Selecting multiple adjacent contacts upwards will also show always the first selected contact, so the preview changes to each focused contact as you go up (although focus isn't shown, another bug). Not bad, but inconsistent with downwards selection. Also less useful than multi-contact summary/actions.
Summary: Selecting multiple contacts in new AB continues to show only the first selected contact (and inconsistency between downwards vs. upwards Shift-selection) → Selecting multiple contacts in new Address Book continues to show only the first selected contact (and inconsistency between downwards vs. upwards Shift-selection)

TB 78/91 both show blank preview for this scenario.

Keywords: regression
Version: unspecified → Thunderbird 99
Summary: Selecting multiple contacts in new Address Book continues to show only the first selected contact (and inconsistency between downwards vs. upwards Shift-selection) → Selecting multiple contacts in new Address Book continues to show only the first selected contact (and inconsistency between downwards vs. upwards Shift-selection) - should show blank preview or summary/actions for selected contacts

I think we need to call detailsPane.displayContact(null) whenever there isn't exactly one selected contact. There's a few possible ways to get into that state.

Assignee: nobody → nicolai

This appears to be working properly now, at least in my understanding of the bug. Care to confirm Thomas?

Flags: needinfo?(bugzilla2007)

(In reply to Ryan Lee Sipes from comment #3)

This appears to be working properly now, at least in my understanding of the bug. Care to confirm Thomas?

Yes, after I filed this on Feb 23, Geoff has finally fixed this on Jun 21 in bug 1774096 (also filed by myself):
D149191 - Fill the Address Book display pane when multiple contacts or lists are selected. r=aleca

Severity: S4 → S3
Status: NEW → RESOLVED
Closed: 2 years ago
Flags: needinfo?(bugzilla2007)
Resolution: --- → FIXED
Whiteboard: [Fixed by bug 1774096]
Target Milestone: --- → 103 Branch

Yes it does work properly. But if you delete the last contacts (multiple selected) of an address book the multiple contacts selected view of the deleted contacts is still shown. Could you confirm this Thomas?

I'd say this is a drastic lower priority then as instead of deleting all contacts via the selection a user might be more tempted to delete the whole address book.

Flags: needinfo?(bugzilla2007)

(In reply to Nicolai Kasper from comment #5)

Yes it does work properly. But if you delete the last contacts (multiple selected) of an address book the multiple contacts selected view of the deleted contacts is still shown. Could you confirm this Thomas?

Yes, this is still happening in 102.1.0 and it's Bug 1777808 to which you're assigned ;-)

I'd say this is a drastic lower priority then as instead of deleting all contacts via the selection a user might be more tempted to delete the whole address book.

I'm not sure if I understand your point here.

Flags: needinfo?(bugzilla2007)
You need to log in before you can comment on or make changes to this bug.