Show the settings to toggle the new performance panel on all channels
Categories
(DevTools :: Performance Tools (Profiler/Timeline), task, P1)
Tracking
(firefox98 fixed, firefox99 fixed)
People
(Reporter: jdescottes, Assigned: jdescottes)
References
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
pascalc
:
approval-mozilla-release+
|
Details |
We overlooked that the DevTools setting to disabled the new perf panel was only on devedition and nightly
We should show the setting on all channels because the onboarding for the new performance panel explicitly mentions that users can temporarily switch back to the old panel.
Without this, the only way users could revert to the old panel is to open about:config and set the pref directly...
Assignee | ||
Comment 1•3 years ago
|
||
Updated•3 years ago
|
Comment 4•3 years ago
|
||
bugherder |
Assignee | ||
Comment 5•3 years ago
|
||
Comment on attachment 9265467 [details]
Bug 1757143 - [devtools] Show the settings to toggle the new performance panel on all channels
Beta/Release Uplift Approval Request
- User impact if declined: We enabled the new DevTools performance panel in Bug 1693316, which landed in Firefox 98, but we offer the option to revert to the old panel temporarily if users want to do so. This is explained in the onboarding message displayed to users. However the checkbox to switch between old and new performance panels is hidden on beta and release at the moment. This patch fixes that.
Can't easily be verified on Nightly since this depends on the release channel.
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Removing a simple
if
condition to display a checkbox which has been present in Nightly and DevEdition for a long time. - String changes made/needed:
Comment 6•3 years ago
|
||
Comment on attachment 9265467 [details]
Bug 1757143 - [devtools] Show the settings to toggle the new performance panel on all channels
This is now an uplift request for the release channel. Approved given that this is a planned feature.
Comment 7•3 years ago
|
||
bugherder uplift |
Description
•