Closed
Bug 1757639
Opened 2 years ago
Closed 2 years ago
Remove operating-system/platform-related preprocessing conditionals from various browser/ CSS files
Categories
(Firefox :: Theme, task, P3)
Tracking
()
RESOLVED
FIXED
100 Branch
People
(Reporter: Gijs, Assigned: sclements)
References
Details
(Whiteboard: [fidefe-2022-mr1-css-linting])
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
Specifically, these files:
browser/base/content/browser.css
browser/themes/shared/browser.inc.css
browser/themes/shared/customizableui/panelUI.inc.css
browser/themes/shared/notification-icons.inc.css
browser/themes/shared/places/places-tooltip.inc.css
browser/themes/shared/sidebar.inc.css
browser/themes/shared/toolbarbutton-icons.inc.css
All have ifdefs in for macOS/Windows/Linux (or gtk)/Android. They can all be replaced with the relevant -moz-platform ifdefs. browser.css has some other ifdefs (for MENUBAR_CAN_AUTOHIDE) that can be left for this bug, they are covered by bug 1752833.
It may be necessary to remove the * mark in front of the relevant files in jar.mn if these files are now @import'd instead of included
|
Reporter | |
Updated•2 years ago
|
Severity: -- → N/A
Type: defect → task
Priority: -- → P3
|
||
Updated•2 years ago
|
|
||
Updated•2 years ago
|
Points: --- → 3
|
Assignee | |
Updated•2 years ago
|
Assignee: nobody → sclements
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•2 years ago
|
||
|
||
Updated•2 years ago
|
Attachment #9266864 -
Attachment description: WIP: Bug 1757639 - Remove preprocessor from remaining browser/theme/shared files → Bug 1757639 - Remove preprocessor from remaining browser/theme/shared files r=Gijs
|
|
Assignee | |
Updated•2 years ago
|
Points: 3 → 1
Pushed by sclements@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/26fd063a944b Remove preprocessor from remaining browser/theme/shared files r=Gijs
|
||
Comment 3•2 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox100:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 100 Branch
|
||
Updated•2 years ago
|
|
||
Updated•2 years ago
|
Component: General → Theme
You need to log in
before you can comment on or make changes to this bug.
Description
•