Closed
Bug 1757642
Opened 3 years ago
Closed 3 years ago
Remove operating-system/platform-related preprocessing conditionals from arrowscrollbox.css and menu.css
Categories
(Toolkit :: General, task, P3)
Tracking
()
RESOLVED
FIXED
100 Branch
| Tracking | Status | |
|---|---|---|
| firefox100 | --- | fixed |
People
(Reporter: Gijs, Assigned: sclements)
References
Details
(Whiteboard: [fidefe-2022-mr1-css-linting])
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
The arrowscrollbox.css shared css file has a macOS specific rule that can just be moved into a media query.
menu.css is a funny case. It's a windows-specific file but it has an ifdef for XP_WIN. So what gives? Well, we used to support OS/2, and in bug 461650, 14 years ago, OS/2 people complained that we shouldn't change the menu styling in background windows there. We don't support OS/2 anymore, and the OS/2 ports of Firefox have all died off a few years back for various reasons. So I'd say we could probably just remove the conditional entirely.
|
||
Updated•3 years ago
|
|
||
Updated•3 years ago
|
Points: --- → 1
|
Assignee | |
Updated•3 years ago
|
Assignee: nobody → sclements
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•3 years ago
|
||
Pushed by sclements@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/dbbcfe333292
remove ifdef from arrowscroll.css and windows menu.css r=sfoster
|
||
Comment 3•3 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox100:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 100 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•