Typo in CalMemoryCalendar use of the displayName property.
Categories
(Calendar :: Provider: CalDAV, defect)
Tracking
(thunderbird_esr91+ fixed)
People
(Reporter: lasana, Assigned: lasana)
References
(Regression)
Details
(Keywords: regression)
Attachments
(2 files)
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
patch
|
wsmwk
:
approval-comm-esr91+
|
Details | Diff | Splinter Review |
The property is a getter but is used like a function in get shortName
. This will throw an error but I don't see it in the console during regular use. Maybe because we catch any errors in some places?
I did encounter the error while stepping through the debugger however.
Assignee | ||
Comment 1•3 years ago
|
||
I thought I fixed this in another bug but looks like I did not.
Assignee | ||
Comment 2•3 years ago
|
||
Updated•3 years ago
|
Assignee | ||
Updated•3 years ago
|
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/7489cd9ab11a
Fix displayName typo in memory calendar. r=aleca
Updated•3 years ago
|
Assignee | ||
Comment 4•3 years ago
|
||
Comment on attachment 9266078 [details]
Bug 1757750 - Fix displayName typo in memory calendar. r=#thunderbird-reviewers
[Approval Request Comment]
Regression caused by (bug #): 1724071
User impact if declined: Not much. This might fail silently.
Testing completed (on c-c, etc.): trunk
Risk to taking this patch (and alternatives if risky):
Low risk, I'm attaching an esr only patch because of failed hunks.
Assignee | ||
Comment 5•3 years ago
|
||
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Comment 6•3 years ago
|
||
Comment on attachment 9272170 [details] [diff] [review]
bug1757750-esr.patch
[Approval Request Comment]
Regression caused by (bug #): 1724071
User impact if declined: Not much. This might fail silently.
Testing completed (on c-c, etc.): trunk
Risk to taking this patch (and alternatives if risky):
Low risk, I'm attaching an esr only patch because of failed hunks.
Updated•3 years ago
|
Comment 7•3 years ago
|
||
Comment on attachment 9272170 [details] [diff] [review]
bug1757750-esr.patch
[Triage Comment]
Approved for esr91
Comment 8•3 years ago
|
||
bugherder uplift |
Thunderbird 91.9.0:
https://hg.mozilla.org/releases/comm-esr91/rev/3b34853658c4
Description
•