Closed Bug 1757750 Opened 3 years ago Closed 3 years ago

Typo in CalMemoryCalendar use of the displayName property.

Categories

(Calendar :: Provider: CalDAV, defect)

defect

Tracking

(thunderbird_esr91+ fixed)

RESOLVED FIXED
99 Branch
Tracking Status
thunderbird_esr91 + fixed

People

(Reporter: lasana, Assigned: lasana)

References

(Regression)

Details

(Keywords: regression)

Attachments

(2 files)

The property is a getter but is used like a function in get shortName. This will throw an error but I don't see it in the console during regular use. Maybe because we catch any errors in some places?

I did encounter the error while stepping through the debugger however.

I thought I fixed this in another bug but looks like I did not.

Status: NEW → ASSIGNED
Regressed by: 1724071
Target Milestone: --- → 99 Branch

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/7489cd9ab11a
Fix displayName typo in memory calendar. r=aleca

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED

Comment on attachment 9266078 [details]
Bug 1757750 - Fix displayName typo in memory calendar. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #): 1724071
User impact if declined: Not much. This might fail silently.
Testing completed (on c-c, etc.): trunk
Risk to taking this patch (and alternatives if risky):
Low risk, I'm attaching an esr only patch because of failed hunks.

Attachment #9266078 - Flags: approval-comm-esr91?
Attached patch bug1757750-esr.patch (deleted) — Splinter Review
Attachment #9266078 - Flags: approval-comm-esr91?

Comment on attachment 9272170 [details] [diff] [review]
bug1757750-esr.patch

[Approval Request Comment]
Regression caused by (bug #): 1724071
User impact if declined: Not much. This might fail silently.
Testing completed (on c-c, etc.): trunk
Risk to taking this patch (and alternatives if risky):
Low risk, I'm attaching an esr only patch because of failed hunks.

Attachment #9272170 - Flags: approval-comm-esr91?

Comment on attachment 9272170 [details] [diff] [review]
bug1757750-esr.patch

[Triage Comment]
Approved for esr91

Attachment #9272170 - Flags: approval-comm-esr91? → approval-comm-esr91+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: