set mimetype for parts in crash report for content crashes
Categories
(Toolkit :: Crash Reporting, enhancement)
Tracking
()
Tracking | Status | |
---|---|---|
firefox101 | --- | fixed |
People
(Reporter: willkg, Assigned: gsvelto)
References
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
This code here:
sets the mimetype only for the JSON-encoded extra field, but not for other parts.
It should set the mimetype for minidumps to application/octet-stream
. I think it should do the same for memory_report
, but ... I don't know what format that's in.
This is all to alleviate parsing problems and get crash reporting closer to the current crash report payload spec (https://socorro.readthedocs.io/en/latest/spec_crashreport.html).
Reporter | ||
Comment 1•3 years ago
|
||
I don't know offhand how much it affects crash ingestion. I'm guessing there might be edge cases where it causes things to go awry, but otherwise doesn't affect things as they stand currently. It was a bit of a surprise earlier this week, though.
I can probably do this work if we're agreed on the problem statement and plan and someone tells me what mimetype to use for memory_report
.
Assignee | ||
Comment 2•3 years ago
|
||
Updated•3 years ago
|
Assignee | ||
Comment 3•3 years ago
|
||
I haven't landed this yet because I was looking for a way to test it using the minimal crash reporter server simulator in m-c... and while I was testing I noticed that the MIME types weren't being populated correctly even after my change. It seems that somehow we're still picking up the overrides in /etc/mime.types
instead.
Reporter | ||
Comment 4•3 years ago
|
||
I've been thinking about creating a mini-collector that you could do an HTTP POST to and it would let you assert things through an API about the extracted payload. Does that sound like something that would help here?
Assignee | ||
Comment 5•3 years ago
|
||
It could be useful for doing more sensible integration testing, right now we use this which is very limited as you can see.
Comment 7•3 years ago
|
||
bugherder |
Description
•